-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Improve task bar design
#10095
Programming exercises
: Improve task bar design
#10095
Conversation
Programming Exercises
: Implement new task bar designProgramming exercises
: Implement new task bar design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts4. Changes look good to me in normal programming exercises and in exam mode programming exercises :)
Btw.: You can easily pass the bubble sort test in the example exercises using
Collections.sort(input);
;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts3, the progress bar has the correct view before and after pushing 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Everything looks as described.
Honestly I liked the old design though, the grey background made the progress bar stand out more and the dots were a bit bigger, but I guess that's just taste, maybe I just got used to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3, everything works as expected, the new design looks clean.
Programming exercises
: Implement new task bar designProgramming exercises
: Improve task bar design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new design looks awesome 👍 Thank you @PaRangger for the implementation and thanks to @rabeatwork for the Figma mockups
Checklist
General
Client
Motivation and Context
Currently, the task bar in a programming exercise looks a bit out of place. It looks like this:
There was a design mockup on figma for a new task bar here: https://www.figma.com/design/BGx58G5OhhCUOToD6cPKQA/Artemis-Navigation-Flow?node-id=4165-64510&m=dev&t=7vXtR0SZJZA94hEN-1
Description
I changed the html and css so that the design looks more like the design in figma.
Steps for Testing
Prerequisites:
You may take this to have a successful test in bubble sort:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit
UI/UX Improvements
Style Updates