-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Introduce text module API
#10043
base: chore/introduce-atlas-profile
Are you sure you want to change the base?
Development
: Introduce text module API
#10043
Conversation
Development
: Introduce text module-/Java-API
Development
: Introduce text module-/Java-APIDevelopment
: Introduce text module API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟩: Works well
🟨: Works partially
🟥: Doesn't work
I tested the following:
🟨 Creating a text exercise
🟨 Edit the text exercise
🟨 Create an example submission (When changing the Assessment Training, then clicking on Update example submission, the view only gets updated when I reload the page, can we make it so that on clicking update submission, the view also gets updated. Also when I add an assessment when the Assessment Training is Assess Correctly, then change to Read and Confirm then back to Assess Correctly, the assessment is gone. Also the assessment is also gone when I click on Update example Submission then reload without changing anything. This is probably not related to this PR, I think I would mention this in an issue)
🟥 Import the student submission as example submission (I made a submission with test user 1 and another with test user 20 but when trying to import submissions, it says that it can't find the students' submissions)
🟥 Export the example submissions (I couldn't find the button to export example submissions)
🟨 Import the exercise into a new course
🟩 Delete the exercise in both courses
When clicking into create new or edit or import a text exercise, I had these problems. However the creation or the changes while edit as well as the import still works, for the import I have to reload the page and then go back to the Exercises Overiview to see the newly imported exercise
🟩 Create an exam
🟩 Create a text exercise in the exam
🟩 Import the created text exercise from 2 into the exam
🟨 Participate in the exam and make submissions: When I try to submit it early I got a Bad Request, however it still goes through
Checklist
General
Server
Motivation and Context
As part of the server modularization, we "facade" the service/repository declaration and method calls to module-external classes via a module API provided by the respective module.
Description
These changes add the module API for text exercises.
Out of scope: Adding a
PROFILE_TEXT
to disable the module on server start. This requires a lot of frontend changes and testing.Steps for Testing
Basically try to test all the functionality of text exercises regarding submissions, courses, and import/export.
Exam Mode Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test