Adaptive learning: Omit competency taxonomy icon on dashboard if no t…

…axonomy is set (#8809)
ls1intum · Jun 18, 2024 · 5c71468 · 5c71468
1 parent 7083d42
commit 5c71468
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...n/webapp/app/course/competencies/competency-accordion/competency-accordion.component.html b/...n/webapp/app/course/competencies/competency-accordion/competency-accordion.component.html
@@ -6,12 +6,14 @@
         (click)="toggle()"
     >
         <h4 class="fw-medium mb-0 py-2 col-sm-6 d-flex gap-2">
-            <fa-icon
-                [icon]="getIcon(competency.taxonomy)"
-                [fixedWidth]="true"
-                [ngbTooltip]="'artemisApp.competency.taxonomies.' + competency.taxonomy | artemisTranslate"
-                container="body"
-            />
+            @if (competency.taxonomy) {
+                <fa-icon
+                    [icon]="getIcon(competency.taxonomy)"
+                    [fixedWidth]="true"
+                    [ngbTooltip]="'artemisApp.competency.taxonomies.' + competency.taxonomy | artemisTranslate"
+                    container="body"
+                />
+            }
             {{ competency.title }}
         </h4>
         <div class="w-100 d-flex align-items-center gap-4">

diff --git a/src/main/webapp/app/entities/student-metrics.model.ts b/src/main/webapp/app/entities/student-metrics.model.ts
@@ -71,7 +71,7 @@ export class CompetencyInformation {
     public id: number;
     public title: string;
     public description: string;
-    public taxonomy: CompetencyTaxonomy;
+    public taxonomy?: CompetencyTaxonomy;
     public softDueDate?: dayjs.Dayjs;
     public optional: boolean;
     public masteryThreshold: number;