Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jqwik from 1.3.4 to 1.5.6 #140

Closed
wants to merge 9 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 17, 2021

Bumps jqwik from 1.3.4 to 1.5.6.

Release notes

Sourced from jqwik's releases.

Rounding up the 1.5 Series

New and Enhanced Features

  • Upgraded to JUnit platform 1.8.0

  • Improved performance of large collection generation. See jlink/jqwik#227.

Breaking Changes

  • Parameters for StringArbitrary.ofMinLength() and StringArbitrary.ofMaxLength() are validated. See jlink/jqwik#221.

Bug Fixes

  • Added reporting format for type char[].

  • @StatisticsReport(onFailureOnly = true) now also works when failure is a statistics check failure.

Stabilizing 1.5.x

New and Enhanced Features

  • You can now add footnotes to failure reports

  • Added StatisticsReport.onFailureOnly() to suppress statistics reporting for properties that do not fail.

  • Shrinking across several for-all parameters has been improved.

  • The Web module now supports web domain name generation.

  • The Time module now supports the generation of java.time.OffsetDateTime instances.

Breaking Changes

  • Properties with single try (aka examples) with at least one @ForAll parameter will now produce a test report even if they succeed. See jlink/jqwik#217.

Bug Fixes

Builders Overhauled

New and Enhanced Features

  • Added default method DomainContext.initialize(PropertyLifecycleContext) which

... (truncated)

Changelog

Sourced from jqwik's changelog.

1.5.6

New and Enhanced Features

  • Upgraded to JUnit platform 1.8.0

  • Improved performance of large collection generation. See jlink/jqwik#227.

Breaking Changes

  • Parameters for StringArbitrary.ofMinLength() and StringArbitrary.ofMaxLength() are validated. See jlink/jqwik#221.

Bug Fixes

  • Added reporting format for type char[].

  • @StatisticsReport(onFailureOnly = true) now also works when failure is a statistics check failure.

1.5.5

New and Enhanced Features

  • You can now add footnotes to failure reports

  • Added StatisticsReport.onFailureOnly() to suppress statistics reporting for properties that do not fail.

  • Shrinking across several for-all parameters has been improved.

  • The Web module now supports web domain name generation.

  • The Time module now supports the generation of java.time.OffsetDateTime instances.

... (truncated)

Commits
  • b924915 Generated documentation for 1.5.6
  • d966ae9 Fixed duplicated text in release-notes
  • 82535c2 Update TODO and BACKLOG
  • bcda2e9 Update TODO
  • ef2e0c9 Make EqualDistributionTests more robust
  • 7e7eacd Validate StringArbitrary.ofMinLength|ofMaxLength
  • 02d25d2 @​StatisticsReport(onFailureOnly = true) now works with failing statistics checks
  • 84521be Adapted tests for generating large lists
  • da4a521 Fixed JDK8 compiler type inference issue
  • 7090d7a Added arbitrary.list().unique() tests
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 17, 2021
@dependabot dependabot bot force-pushed the dependabot/maven/net.jqwik-jqwik-1.5.6 branch 2 times, most recently from b93db60 to 2d2403b Compare September 22, 2021 23:20
@MaisiKoleni MaisiKoleni removed their assignment Oct 1, 2021
@dependabot dependabot bot force-pushed the dependabot/maven/net.jqwik-jqwik-1.5.6 branch from 2d2403b to 88aa387 Compare October 22, 2021 03:39
@dependabot dependabot bot force-pushed the dependabot/maven/net.jqwik-jqwik-1.5.6 branch from 88aa387 to 54b33c3 Compare November 1, 2021 16:15
Bumps [jqwik](https://github.com/jlink/jqwik) from 1.3.4 to 1.5.6.
- [Release notes](https://github.com/jlink/jqwik/releases)
- [Changelog](https://github.com/jlink/jqwik/blob/main/docs/release-notes.md)
- [Commits](jqwik-team/jqwik@1.3.4...1.5.6)

---
updated-dependencies:
- dependency-name: net.jqwik:jqwik
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@krusche
Copy link
Member

krusche commented Nov 11, 2021

@MaisiKoleni any plans when you will merge this PR?

@MaisiKoleni
Copy link
Collaborator

MaisiKoleni commented Nov 11, 2021

@MaisiKoleni any plans when you will merge this PR?

@krusche The problem here is that jqwik has changed the way the test values are internally generated in versions >= 1.3.5. It now submits tasks to the common pool, and the problem here is that Ares does not trust the common pool.
Either a workaround is required or a fix for #15. Both is likely not trivial. I can look into that again, if needed. Until now, no one was interested in having support for up-to-date jqwik.

Also note that there were already many PRs over the last year for previous version updates (auto-closed by the bot).

@MaisiKoleni
Copy link
Collaborator

Had a brief look at it once more, apparently, the execution changed again. It seems doable now, and I will try to fix this quickly. But I cannot give any guarantees that everything in jqwik will work as it would without Ares, there might still be inconsistencies.

@MaisiKoleni
Copy link
Collaborator

MaisiKoleni commented Nov 11, 2021

Regarding the last commit, this might be both more dangerous but offer a solution to some degree for #15. But it seems fragile, and I don't completely understand the behavior of the class file loading. It requires more investigation and would be a breaking change. Currently, I would suggest making it only available via a separate option (trust common pool / all threads).

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 15, 2021

A newer version of net.jqwik:jqwik exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@MaisiKoleni MaisiKoleni changed the title Bump jqwik from 1.3.4 to 1.5.6 Bump jqwik from 1.3.4 to 1.6.0 Nov 17, 2021
@MaisiKoleni MaisiKoleni self-assigned this Nov 17, 2021
@MaisiKoleni MaisiKoleni added the enhancement New feature or request label Nov 17, 2021
…om:ls1intum/artemis-java-test-sandbox.git into dependabot/maven/net.jqwik-jqwik-1.5.6
@MaisiKoleni MaisiKoleni deleted the dependabot/maven/net.jqwik-jqwik-1.5.6 branch November 18, 2021 21:10
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 18, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@MaisiKoleni MaisiKoleni changed the title Bump jqwik from 1.3.4 to 1.6.0 Bump jqwik from 1.3.4 to 1.5.6 Nov 18, 2021
@MaisiKoleni
Copy link
Collaborator

@dependabot ignore this major version

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 18, 2021

OK, I won't notify you about version 1.x.x again, unless you re-open this PR or update to a 1.x.x release yourself.

@MaisiKoleni
Copy link
Collaborator

Continued in #157 due to new version and increasing PR complexity.

@MaisiKoleni MaisiKoleni restored the dependabot/maven/net.jqwik-jqwik-1.5.6 branch January 17, 2022 13:01
@MaisiKoleni MaisiKoleni deleted the dependabot/maven/net.jqwik-jqwik-1.5.6 branch January 17, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants