Feature/paginate through all jobs list #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govrin
approved these changes
Sep 26, 2023
ItzikBH
approved these changes
Sep 26, 2023
lquerel
requested changes
Sep 26, 2023
|
|
||
| let process_resp: Result<JobList, BQError> = process_response(resp).await; | ||
|
|
||
| yield Ok(process_resp.as_ref().expect("JobList is not present").clone()); |
There was a problem hiding this comment.
A missing JobList should not be treated as a fatal error. Therefore, this expect should be replaced with a BQError to allow the caller to handle this error appropriately.
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub parent_job_id: Option<String>, | ||
| /// Restrict information returned to a set of selected fields. Acceptable values are: full or minimal. | ||
| #[serde(skip_serializing_if = "Option::is_none", deserialize_with = "deserialize_projection")] |
There was a problem hiding this comment.
Why not use an enum with two variants: full and minimal, and let Serde handle the serialization?
|
I made few changes to your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to allow users to paginate through all the jobs in the jobs list. It is helpful as it allows people to obtain all of the jobs from the list jobs API.
Also, fix a bug in
JobListJobsandJobstruct, the API sendsuser_emailin this format and not in camel case like in the struct.