Draft: Add Message and Enum support for Storage Write API #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry-client into storage_write_records
|
@fore5fire #112 is merged. Thanks |
|
@fore5fire Do you still want to make changes to this draft, or would you like me to take over from here? |
|
Got sidetracked from this with the holidays, I can take another look this weekend though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #112, so I'll leave it as a draft until that is merged (and I assume the same test failure there will show up here). I also want to add unit tests for messages and enums before this gets merged.
I went ahead and added some convenience constructors to help reduce breaking changes for people that are using simple, flat protos. Even though I'm pretty sure this change gives us full support all types BigQuery has documented, I imagine as this gets used we'll run into some quirks in BigQuery that may require further changes to accommodate.