Merge pull request #162 from proformance/fix_marker_ontap

Solves inability to open popup
lpongetti · May 31, 2023 · a7eb38b · a7eb38b
2 parents 62e6cbc + 999cd68
commit a7eb38b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/lib/src/marker_cluster_layer.dart b/lib/src/marker_cluster_layer.dart
@@ -174,7 +174,6 @@ class _MarkerClusterLayerState extends State<MarkerClusterLayer>
         onTap: _onMarkerTap(marker),
         onHover: (bool value) => _onMarkerHover(marker, value),
         buildOnHover: widget.options.popupOptions?.buildPopupOnHover ?? false,
-        hoverOnTap: () => widget.options.onMarkerTap!(marker),
       ),
     );
   }

diff --git a/lib/src/marker_widget.dart b/lib/src/marker_widget.dart
@@ -19,17 +19,16 @@ class MarkerWidget extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     final m = marker.builder(context);
-    return buildOnHover
-        ? GestureDetector(
-            behavior: HitTestBehavior.opaque,
-            onTap: hoverOnTap ?? onTap,
-            child: onHover != null
-                ? MouseRegion(
-                    onEnter: (_) => onHover!(true),
-                    onExit: (_) => onHover!(false),
-                    child: m,
-                  )
-                : m)
-        : m;
+    return GestureDetector(
+      behavior: HitTestBehavior.opaque,
+      onTap: hoverOnTap ?? onTap,
+      child: onHover != null
+          ? MouseRegion(
+              onEnter: (_) => onHover!(true),
+              onExit: (_) => onHover!(false),
+              child: m,
+            )
+          : m,
+    );
   }
 }