Add embedded-hal alpha and embedded-time support to MRT #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step in preparation for implementing the `CountDown` trait from the alpha version of embedded-hal. These have different names (`try_` prefix) and are fallible. Since we will most likely drop support for the old version of embedded-hal at some point, I thought it best to add the infallible versions as inherent methods now, instead of having to make another change later.
I think that the library looks really nice and has the potential to become a de-facto standard across the ecosystem.
david-sawatzke
approved these changes
Oct 17, 2020
|
CI fails because embedded-time doesn't compile on nightly. See FluenTech/embedded-time#78 and rust-lang/rust#77638. Since a fix has already been merged in embedded-time, I assume it will make its way to crates.io sooner or later, and we won't have issues here. Merging, as the PR is already approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.