Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for embedded-hal 1.0.0-alpha.1 #287

Merged
merged 9 commits into from
Oct 15, 2020
Merged

Add partial support for embedded-hal 1.0.0-alpha.1 #287

merged 9 commits into from
Oct 15, 2020

Conversation

hannobraun
Copy link
Member

I've decided to start with the traits that I need right now (GPIO and delay), rather than trying to do everything, which I neither have the time to do nor to test. I figure we can extend support as needed.

Contains some other random commits in addition to the embedded-hal stuff. Those were things I happened upon while working on this, and I figure they're minor enough to not need their own pull request.

Copy link
Member

@david-sawatzke david-sawatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I feel about having editor specific config, but VSCode makes the most sense (unfortunately, emacs4ever!).

src/delay.rs Outdated Show resolved Hide resolved
src/delay.rs Outdated Show resolved Hide resolved
src/delay.rs Outdated Show resolved Hide resolved
@hannobraun
Copy link
Member Author

Thanks for the review! It baffles me that I managed to find and correct subtle changes in some comments, but then somehow copy-pasted the large inappropriate one without much thought. I'll push an update later.

Not sure how I feel about having editor specific config, but VSCode makes the most sense (unfortunately, emacs4ever!).

As long as it's not some crazy file format that requires regular maintenance, this kind of configuration is very helpful to users of the editor in question, while having little to no impact on users of other editors. I see little reason to reject this kind of thing, especially from regular contributors. I'd be happy to merge Emacs configuration, if that's helpful to you.

@hannobraun
Copy link
Member Author

Rebased (no changes required); added a commit that shortens the inappropriate comments.

Copy link
Member

@david-sawatzke david-sawatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! I have nothing emacs specific, at least nothing that would make sense.

@hannobraun hannobraun merged commit 39c548a into lpc-rs:master Oct 15, 2020
@hannobraun hannobraun deleted the embedded-hal-alpha branch October 15, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants