Trying tests in the build action

lowleveldesign · Dec 5, 2024 · 3758218 · 3758218
1 parent 706c7f3
commit 3758218
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -18,9 +18,8 @@ jobs:
       with:
         dotnet-version: '9.0.x' # SDK Version to use.
 
-# Lots of tests now require a GUI environment - I need to categorize them and allow only a small set here
-#    - run: dotnet test -c release
-#      working-directory: ./procgov-tests
+    - run: dotnet test -c release --filter "FullyQualifiedName~ProcessGovernor.Tests.Code.ProgramTests"
+      working-directory: ./procgov-tests
 
     - run: dotnet publish -c release -r win-x64
       working-directory: ./procgov

diff --git a/procgov-tests/Code/ProgramTests_CmdApp.cs b/procgov-tests/Code/ProgramTests_CmdApp.cs
@@ -80,7 +80,7 @@ public static async Task CmdAppAttachProcessAndUpdateJob()
     {
         using var cts = new CancellationTokenSource(10000);
 
-        var (cmd, cmdMainThreadHandle) = ProcessModule.CreateSuspendedProcess(["cmd.exe"], false, []);
+        var (cmd, cmdMainThreadHandle) = ProcessModule.CreateSuspendedProcess(["cmd.exe", "/c", "pause 4"], false, []);
         try
         {
             PInvoke.ResumeThread(cmdMainThreadHandle);

diff --git a/procgov-tests/Code/ProgramTests_Service.cs b/procgov-tests/Code/ProgramTests_Service.cs
@@ -264,10 +264,15 @@ public static async Task ServiceChildProcessLimit()
             // sure that it will treat our newly started process as new
             await Task.Delay(Program.ServiceProcessObserverIntervalInMilliseconds * 2, cts.Token);
 
-
-            const int ChildProcessTimeoutSeconds = 4;
+            const int ChildProcessTimeoutSeconds = Program.ServiceProcessObserverIntervalInMilliseconds * 3 / 1000;
             // the monitor should start with the first monitored process
-            using var monitoredProcess = Process.Start("cmd.exe", $"/c timeout /T {ChildProcessTimeoutSeconds} && winver.exe");
+            using var monitoredProcess = Process.Start(new ProcessStartInfo()
+            {
+                FileName = "cmd.exe",
+                Arguments = $"/c timeout /T {ChildProcessTimeoutSeconds} && winver.exe",
+                UseShellExecute = true
+            });
+            Debug.Assert(monitoredProcess != null);
             Program.Logger.TraceInformation($"[test] {nameof(monitoredProcess)}.Id = {monitoredProcess.Id}");
 
             // give it time to discover a new process
@@ -288,7 +293,7 @@ public static async Task ServiceChildProcessLimit()
 
                 await Task.Delay((ChildProcessTimeoutSeconds + 1) * 1000, cts.Token);
 
-                using var childProcess = Process.GetProcessesByName("winver").First(p => p.StartTime > monitoredProcess.StartTime);
+                using var childProcess = Process.GetProcessesByName("winver").First(p => p.StartTime >= monitoredProcess.StartTime);
                 Program.Logger.TraceInformation($"[test] {nameof(childProcess)}.Id = {childProcess.Id}");
 
                 try