Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Layout Fixes/Updates #510

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Nav Layout Fixes/Updates #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a5831f
Merge pull request #507 from lowcoder-org/dev
FalkWolsky Nov 19, 2023
6e1bc05
fix: handle empty itemKeys for sub-menus
raheeliftikhar5 Nov 14, 2023
48e4c71
feat: allow more than 2 levels nested nav
raheeliftikhar5 Nov 14, 2023
ee148f5
feat: make parent menu items clickable
raheeliftikhar5 Nov 14, 2023
8e39c18
feat: added width and background option for nav bar
raheeliftikhar5 Nov 14, 2023
ce51a67
feat: styling option for nav layout
raheeliftikhar5 Nov 16, 2023
4be209b
feat: background-image for nav layout
raheeliftikhar5 Nov 16, 2023
b06fa7e
feat: allow json data for nav layout
raheeliftikhar5 Nov 20, 2023
a3389a4
Merge branch 'dev' into nav-layout-updates
FalkWolsky Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions client/packages/lowcoder/src/comps/comps/layout/layoutMenuItemComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,13 @@ export class LayoutMenuItemComp extends MultiBaseComp<ChildrenType> {
}

override getPropertyView(): ReactNode {
const isLeaf = this.children.items.getView().length === 0;
return (
<>
{isLeaf &&
this.children.action.propertyView({
onAppChange: (label) => {
label && this.children.label.dispatchChangeValueAction(label);
},
})}
{this.children.action.propertyView({
onAppChange: (label) => {
label && this.children.label.dispatchChangeValueAction(label);
},
})}
{this.children.label.propertyView({ label: trans("label") })}
{this.children.icon.propertyView({
label: trans("icon"),
Expand Down Expand Up @@ -98,12 +96,17 @@ const LayoutMenuItemCompMigrate = migrateOldData(LayoutMenuItemComp, (oldData: a
export class LayoutMenuItemListComp extends list(LayoutMenuItemCompMigrate) {
addItem(value?: any) {
const data = this.getView();

this.dispatch(
this.pushAction(
value || {
label: trans("menuItem") + " " + (data.length + 1),
itemKey: genRandomKey(),
}
value
? {
...value,
itemKey: value.itemKey || genRandomKey(),
} : {
label: trans("menuItem") + " " + (data.length + 1),
itemKey: genRandomKey(),
}
)
);
}
Expand Down
Loading