Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc API Key Feature Updates #446

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

aq-ikhwa-tech
Copy link
Contributor

Proposed changes

  • Add LOWCODER_API_SECRET_KEY env var for existing installations to work without having to rebuild images/containers
  • (Good to have) Base64 encoded the secret key as per requirement of the function definition

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for lowcoder-cloud canceled.

Name Link
🔨 Latest commit 2c4cc5a
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/653a526490caf600089d057c

@aq-ikhwa-tech aq-ikhwa-tech changed the base branch from main to dev October 26, 2023 11:50
@ludomikula ludomikula merged commit bb83ac4 into dev Oct 26, 2023
@ludomikula ludomikula deleted the add-env-var-to-docker-images branch October 26, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants