Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker compose syntax to Compose V2 and add healthchecks #1387

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

martkaczmarek
Copy link
Contributor

@martkaczmarek martkaczmarek commented Dec 11, 2024

Proposed changes

docker-compose command syntax and "version" tag in docker-compose files imply the Compose V1, which stopped receiving updates and is deprecated for over a year now:
https://docs.docker.com/compose/releases/migrate/
I updated all the compose files and "docker compose" commands in documentation to reflect the V2 syntax.

I also added healthchecks for docker containers to ensure containers start only when the dependencies are in 'healthy' state, noty only 'started'.
The update to V2 is needed to use health condition in "depends_on" section.

This is a potentially breaking change if somebody updates the docker-compose file and doesn't have appropriate docker update.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

FalkWolsky and others added 2 commits December 4, 2024 22:35
Added healthchecks and conditions for dependant containers to start only when container's healthy state is confirmed
Copy link

netlify bot commented Dec 11, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b21f14d

@ludomikula
Copy link
Collaborator

Can I please ask you to squash the "Update docker compose syntax to Compose V2" commits?

Update docker compose syntax to Compose V2
@martkaczmarek
Copy link
Contributor Author

@ludomikula Done

@ludomikula ludomikula changed the base branch from main to dev December 16, 2024 23:53
@ludomikula ludomikula merged commit 3598854 into lowcoder-org:dev Dec 16, 2024
2 checks passed
@ludomikula
Copy link
Collaborator

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants