Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented pagination in some APIs. #1351

Merged
merged 39 commits into from
Dec 4, 2024
Merged

Implemented pagination in some APIs. #1351

merged 39 commits into from
Dec 4, 2024

Conversation

Imiss-U1025
Copy link
Collaborator

Proposed changes

Implemented pagination in some APIs.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 0364857
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/675035a680a05e0008f88e4d
😎 Deploy Preview https://deploy-preview-1351--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

FalkWolsky
FalkWolsky previously approved these changes Nov 28, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this truly helpful adaption of Search!

@Imiss-U1025
Copy link
Collaborator Author

There are still some issues that need to be fixed. Let me fix it soon.

@Imiss-U1025 Imiss-U1025 force-pushed the feature-pagination branch 5 times, most recently from 7d2a7a9 to c494a23 Compare November 29, 2024 11:46
@Imiss-U1025
Copy link
Collaborator Author

Imiss-U1025 commented Nov 29, 2024

Sorry, I pushed force without pull to get any update, so I added it in my next commit.

@Imiss-U1025 Imiss-U1025 force-pushed the feature-pagination branch 4 times, most recently from 91c30c7 to 346760c Compare December 2, 2024 21:17
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very very much. This is a great change and solves usability for so many users!

@FalkWolsky FalkWolsky merged commit 6aced74 into dev Dec 4, 2024
7 of 8 checks passed
@FalkWolsky FalkWolsky deleted the feature-pagination branch December 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants