nil pointer panic when closing producer #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #49. The issue is that we were closing the stop channel and the underlying producer at the same time. Since the select in
run()
is non-deterministic and the channels of the producer (errors and successes) may return nil if they are closed, sometimes the goroutine was getting anil
value back and trying to derefence the Metadata pointer.We now first close the stop channel, that will force the goroutine in
run()
to exit. Afterwards, we close the underlying producer.