Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail in partition view #16

Merged
merged 2 commits into from
May 18, 2017
Merged

Fail in partition view #16

merged 2 commits into from
May 18, 2017

Conversation

db7
Copy link
Collaborator

@db7 db7 commented May 9, 2017

No description provided.

@db7 db7 requested review from SamiHiltunen and frairon May 9, 2017 15:23
frairon
frairon reviewed May 9, 2017
View reviewed changes
Copy link
Contributor

@frairon frairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no unit tests on that? :P

@frairon
Copy link
Contributor

frairon commented May 9, 2017

I can write the tests tomorrow if you want, no problem :)

@frairon
Copy link
Contributor

frairon commented May 10, 2017

never mind the tests. It would be easier to test that using the kafkamock, but that doesn't really support the Joins yet.

@db7 db7 merged commit f589f87 into master May 18, 2017
@db7 db7 deleted the fail-in-partition-view branch May 19, 2017 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frairon frairon frairon approved these changes

@SamiHiltunen SamiHiltunen Awaiting requested review from SamiHiltunen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@db7 @frairon