-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sharp v0.31.1 bug with rotation+resize #3391
Comments
Hi Aaron, thanks for reporting, I can reproduce plus suspect I know what's causing it too (need to harmonise the ordering for flip and flip-due-to-auto-orient). Leave this with me - I'll add your scenario as a test case to prevent regression too. |
Commit eacb833 refactors some of the logic to ensure the flip/flop/rotate operation ordering is consistent, separating auto-orient vs manual orient, plus adds your two scenarios that would previously have failed as new test cases. |
Thank you! |
sharp v0.31.2 now available, thanks for reporting. |
Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?
npm install sharp
completes without error.node -e "require('sharp')"
completes without error.If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?
sharp
as reported bynpm view sharp dist-tags.latest
.What is the output of running
npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp
?What are the steps to reproduce?
https://gist.github.com/asilvas-godaddy/2430fb186c51407ccb90b2900c7fd64a
What is the expected behaviour?
Resizing after rotation should not break rotation. This was caught in test suite from https://github.com/asilvas/node-image-steam
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
https://gist.github.com/asilvas-godaddy/2430fb186c51407ccb90b2900c7fd64a
Please provide sample image(s) that help explain this problem
Source: https://drive.google.com/file/d/176GYzVQ_bj0X57CvZS5CfgiZzFjTAkMl/view?usp=sharing
The rotated output is correct after flip+90deg rotate. But if also resizing, the orientation breaks.
The text was updated successfully, but these errors were encountered: