Skip to content
This repository has been archived by the owner on Aug 17, 2022. It is now read-only.

Fixed half open state transition #5

Merged
merged 1 commit into from
May 13, 2019

Conversation

mickaelandrieu
Copy link
Contributor

@mickaelandrieu mickaelandrieu commented May 13, 2019

HALF_OPEN state is a transitional state and so on the Circuit Breaker can't stay on this state.

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #5 into master will decrease coverage by 0.69%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #5     +/-   ##
==========================================
- Coverage      99.3%   98.6%   -0.7%     
  Complexity      100     100             
==========================================
  Files            18      18             
  Lines           286     287      +1     
==========================================
- Hits            284     283      -1     
- Misses            2       4      +2
Impacted Files Coverage Δ Complexity Δ
src/PartialCircuitBreaker.php 94.87% <100%> (-5.13%) 11 <1> (ø)
src/SimpleCircuitBreaker.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/SymfonyCircuitBreaker.php 97.72% <100%> (ø) 11 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08563b...8037e4c. Read the comment docs.

@mickaelandrieu mickaelandrieu merged commit 360bc81 into master May 13, 2019
@mickaelandrieu mickaelandrieu deleted the fix-invalid-halfopen-transition branch May 13, 2019 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants