Skip to content

Conversation

tpimh
Copy link

@tpimh tpimh commented Sep 3, 2025

Fixes issue #2198

@tpimh tpimh marked this pull request as draft September 3, 2025 10:22
@tpimh
Copy link
Author

tpimh commented Sep 3, 2025

Joint:getType() was returning distance for RopeJoint since Box2D 2.4.1 (because this is what it is now: fc2cf60).

I removed rope value completely, because it became dead code. Maybe it's possible to add some detection logic and return the correct type here:

case e_distanceJoint:
return JOINT_DISTANCE;

@tpimh
Copy link
Author

tpimh commented Sep 3, 2025

Or maybe it's better to just override getType() like this tpimh@9fa0007?

@hexatorum
Copy link

the ci for windows can't find the nsis compiler and fails
but other than that error this looks fine to me, can we merge this now

@tpimh
Copy link
Author

tpimh commented Sep 22, 2025

@hexatorum in current state, this PR removes "rope" JointType completely (it was broken since the last Box2D update). My proposed solution to restore this functionality is here: tpimh@9fa0007. If it looks good to you, I will replace the last commit in this PR with the one from that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants