Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

Configurable timeouts #263

Closed
jangaraj opened this issue Aug 15, 2017 · 1 comment
Closed

Configurable timeouts #263

jangaraj opened this issue Aug 15, 2017 · 1 comment
Assignees

Comments

@jangaraj
Copy link
Contributor

At the moment IdleTimeout is used + it's hardcoded: https://github.com/gambol99/keycloak-proxy/blob/1741a5b3fdf0c5e80656fa64e4a88756d57a390d/server.go#L336-L340

Could you add options to set value of ReadTimeout, WriteTimeout, IdleTimeout please?

Upstream proxy also can implement some timeouts TLSHandshakeTimeout, ResponseHeaderTimeout, ExpectContinueTimeout:
https://github.com/gambol99/keycloak-proxy/blob/1741a5b3fdf0c5e80656fa64e4a88756d57a390d/server.go#L552-L556

Reference:
https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/
https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

@gambol99 gambol99 self-assigned this Aug 18, 2017
gambol99 added a commit that referenced this issue Aug 28, 2017
Related to issue [263](#263). Permitting the users to set varioues timeouts on the http.Server and upstream proxy
gambol99 added a commit that referenced this issue Aug 28, 2017
Related to issue [263](#263). Permitting the users to set varioues timeouts on the http.Server and upstream proxy
gambol99 added a commit that referenced this issue Aug 28, 2017
Related to issue [263](#263). Permitting the users to set varioues timeouts on the http.Server and upstream proxy
gambol99 added a commit that referenced this issue Sep 3, 2017
Related to issue [263](#263). Permitting the users to set varioues timeouts on the http.Server and upstream proxy
@gambol99
Copy link
Contributor

gambol99 commented Sep 3, 2017

fixed in #268

@gambol99 gambol99 closed this as completed Sep 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants