Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate timezones-list lib to @vvo/tzdb issue #4479 #4521

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

huzaifaazim0
Copy link
Contributor

@huzaifaazim0 huzaifaazim0 commented Feb 23, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

migrated timezones-list lib to @vvo/tzdb

Fixes #4479

Type of change

non-breaking

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@chakflying chakflying added area:core issues describing changes to the core of uptime kuma house keeping labels Feb 25, 2024
@chakflying
Copy link
Collaborator

chakflying commented Feb 26, 2024

I took a look at the getTimezoneOffset() function in the front-end, and realized that we are currently using the native Date object to obtain the offset of a Timezone, whereas in the back-end we seem to be using dayjs. The original timezones-list is really just that, a list of timezones for the user to pick. I guess I'm not familiar enough with how these things work to know if it would cause issues.

The code change here looks simple enough, haven't the time to test it yet.

@huzaifaazim0
Copy link
Contributor Author

huzaifaazim0 commented Feb 26, 2024 via email

Copy link
Collaborator

@chakflying chakflying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working okay.

@huzaifaazim0
Copy link
Contributor Author

huzaifaazim0 commented Feb 27, 2024 via email

@louislam louislam added this to the 2.0.0 milestone Mar 3, 2024
@louislam louislam merged commit 8fd713d into louislam:master Mar 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from omsrivastava/timezones-list to vvo/tzdb
3 participants