Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Toast notification timeout settings #3441

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Feat: Toast notification timeout settings #3441

merged 6 commits into from
Sep 6, 2023
+218 −11

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Jul 18, 2023 •
edited
Loading

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #2116
Fixes #1178
Fixes #1085
Fixes #841

This is a continuation of #2555, with various changes applied to improve usability and code organization.

Settings is stored to localStorage on change, so the "Save" button is not needed. Settings are applied to the toast instance default, which will apply to all toast notifications of the same type.

A new button to clear all toast notification is added to the bottom of the toasts stack. The individual close button for each toast is set to show on hover since the close all button should satisfy most needs.

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

image

@chakflying
Copy link
Collaborator Author

Thinking about this, it's probably not a good idea for the setting to affect the system messages. Changed back to the setting affecting monitor toast notifications only.

@CommanderStorm
Copy link
Collaborator

Could you add the following to the PR description?
Resolves #1085
Resolves #841

@chakflying chakflying force-pushed the toast-notification-timeout-setting branch from b909882 to 49ecad4 Compare August 2, 2023 22:44
Computroniks
Computroniks suggested changes Aug 5, 2023
View reviewed changes
src/util-frontend.js Show resolved Hide resolved
src/util-frontend.js Show resolved Hide resolved
src/components/settings/Notifications.vue Outdated Show resolved Hide resolved
src/components/settings/Notifications.vue Outdated Show resolved Hide resolved
src/util-frontend.js Outdated Show resolved Hide resolved
@domdfcoding
Copy link

Are there any instructions for building the docker image from source? I looked but I can only find npm instructions, and my current setup is through docker. I'd like to give this PR a try as it's a feature I'm looking forward to.

@Computroniks
Copy link
Contributor

You should be able to use the pre built docker image for this PR by following these instructions in the wiki
https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests

@louislam louislam added this to the 2.0.0 milestone Aug 10, 2023
@chakflying chakflying force-pushed the toast-notification-timeout-setting branch from 3e70253 to b096586 Compare August 16, 2023 07:40
@chakflying chakflying changed the base branch from master to 2.0.X August 16, 2023 07:40
Berczi Sandor and others added 6 commits August 16, 2023 16:40
@chakflying
Add toast timeout to the settings
a215545 
Changing gui, adding timeout with a fix value

memo

rc

rollback readme

cleanup code

cleanup code

Review fixes

review fix 2
@chakflying
Feat: Add clearAll button below toastContainer
37da3e8
@chakflying
Feat: Load & Apply defaults, improve wording
99c5b33 
Chore: Remove unused
@chakflying
Feat: Change setting to affect monitor notif. only
91d2246
@chakflying @Computroniks
Apply suggestions from code review
cf45b32 
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
@chakflying
Chore: Fix JSDoc
65993e3
@chakflying chakflying force-pushed the toast-notification-timeout-setting branch from 837b5cc to 65993e3 Compare August 16, 2023 08:41
@chakflying chakflying changed the base branch from 2.0.X to master September 3, 2023 20:44
@louislam louislam merged commit bfc7b49 into louislam:master Sep 6, 2023
@CommanderStorm CommanderStorm mentioned this pull request Sep 6, 2023
Closed
7 tasks
@chakflying chakflying deleted the toast-notification-timeout-setting branch September 7, 2023 21:10
@chakflying chakflying mentioned this pull request Dec 17, 2023
Closed
2 tasks
@CommanderStorm CommanderStorm mentioned this pull request Jan 8, 2024
Closed
2 tasks
@CommanderStorm CommanderStorm mentioned this pull request Feb 9, 2024
Closed
@CommanderStorm CommanderStorm mentioned this pull request May 16, 2024
Closed
2 tasks
@CommanderStorm CommanderStorm added the area:dashboard The main dashboard page where monitors' status are shown label May 16, 2024
@CommanderStorm CommanderStorm mentioned this pull request Jul 3, 2024
Closed
@mezza93
Copy link

mezza93 commented Aug 26, 2024

Are there any instructions for building the docker image from source? I looked but I can only find npm instructions, and my current setup is through docker. I'd like to give this PR a try as it's a feature I'm looking forward to.

Sorry but where did you find the instructions for NPM upgrade for this one?

@CommanderStorm
Copy link
Collaborator

See #4500 for the steps where help is appreciated to get v2.0 shipped

@CommanderStorm CommanderStorm mentioned this pull request Oct 13, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Computroniks Computroniks Computroniks requested changes

Assignees
No one assigned
Labels
area:dashboard The main dashboard page where monitors' status are shown
Projects
None yet
Milestone
2.0.0
6 participants
@chakflying @CommanderStorm @domdfcoding @Computroniks @mezza93 @louislam