Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Create Group in EditMonitor page #3379

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Jul 7, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Resolves #3376

Based on feedback from #2692 and #3376, further improve the UX of creating groups:

  • Add simple dialog to create group when in the EditMonitor page.

The "Group Empty" initial beat is a bit annoying, but don't see an easy way to fix it.

Type of change

Please delete any options that are not relevant.

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image
image
image
image

@kokofixcomputers
Copy link
Contributor

Yeah that should make it better. When i first upgraded to the version of uptime kuma that allows you to do some grouping i could not figure out how to create a group. This will be more understandable and more easy

@CommanderStorm
Copy link
Collaborator

@chakflying could you add Resolves #3376 to the description? ^^

@louislam louislam added this to the 1.23.0 milestone Jul 14, 2023
@louislam
Copy link
Owner

Tested, no big issue.

However, the group is pending for the first check. Is it possible to resolve by starting the group later after the monitor has started?

image

@chakflying
Copy link
Collaborator Author

Good suggestion, I implemented it. Code is a bit ugly but works, also resolves the "Group Empty" issue.

@chakflying chakflying force-pushed the feat/edit-monitor-create-group branch 2 times, most recently from 96bb9fe to b1fd676 Compare July 20, 2023 03:34
@louislam
Copy link
Owner

It seems that the last change isn't working properly? It's a blank page for me.

image

@louislam louislam added the question Further information is requested label Jul 31, 2023
@chakflying
Copy link
Collaborator Author

Oops I made a mistake on rebase, will fix later tonight.

@chakflying chakflying force-pushed the feat/edit-monitor-create-group branch from b1fd676 to 3aa06ff Compare July 31, 2023 18:39
@chakflying
Copy link
Collaborator Author

Should be fixed now.

@chakflying chakflying force-pushed the feat/edit-monitor-create-group branch from 3aa06ff to 129d444 Compare August 2, 2023 22:22
extra/gcloud-vm.ps1 Outdated Show resolved Hide resolved
@chakflying chakflying force-pushed the feat/edit-monitor-create-group branch from ce3e290 to 9da0509 Compare August 3, 2023 21:03
@louislam louislam removed the question Further information is requested label Aug 4, 2023
@louislam louislam merged commit a032e11 into louislam:master Aug 4, 2023
@chakflying chakflying deleted the feat/edit-monitor-create-group branch August 16, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do i use Monitor Group on the add monitor as i cant find a way to create a group
4 participants