-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Create Group in EditMonitor page #3379
Feat: Create Group in EditMonitor page #3379
Conversation
Yeah that should make it better. When i first upgraded to the version of uptime kuma that allows you to do some grouping i could not figure out how to create a group. This will be more understandable and more easy |
@chakflying could you add |
Good suggestion, I implemented it. Code is a bit ugly but works, also resolves the "Group Empty" issue. |
96bb9fe
to
b1fd676
Compare
Oops I made a mistake on rebase, will fix later tonight. |
b1fd676
to
3aa06ff
Compare
Should be fixed now. |
3aa06ff
to
129d444
Compare
ce3e290
to
9da0509
Compare
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Resolves #3376
Based on feedback from #2692 and #3376, further improve the UX of creating groups:
The "Group Empty" initial beat is a bit annoying, but don't see an easy way to fix it.
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)