Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Try to close mysql connection properly #3222

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3020

Searched around and there seems to be no way to determine the state of the connection without sending something, so this should be a good enough solution.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Copy link
Contributor

@Zaid-maker Zaid-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@louislam
Copy link
Owner

louislam commented Jun 7, 2023

It is quite surprising that many database libraries in Node.js do not handle connection state gracefully. Perhaps they are designed for long-running applications.

@louislam louislam merged commit 37031fb into louislam:master Jun 7, 2023
@lenisko
Copy link

lenisko commented Jun 7, 2023

thanks!

@chakflying chakflying deleted the fix/mysql-aborted-connection branch June 17, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MariaDB aborts KUMA db connection.
4 participants