Updates 20231223 #559
Merged
Updates 20231223 #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sets the new PreStepStats::proxiesCreated member variable. - Does world.UpdateContacts(conf) handling for any deltaTime; not just when not equal to zero. This means contacts & related manifolds are setup and no longer need updating for a zero time delta as well as any non-zero delta. - Related unit test updates including addition of World.TouchingBodiesWithZeroDeltaTime test to confirm zero delta time behavior for world setup with two touching bodies.
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
Basically moves contact updating out from being only done when the time delta is not zero so that both contacts and manifolds can be made available with a zero delta time call of the world
Stepfunction. Also adds more==&!=support - adding these for thePreStepStats,RegStepStats, andToiStepStatstypes.