Updates 20231218 #552
Merged
Updates 20231218 #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds GetFlags member function to Body to provide read access to the body's flag state. - Uses GetFlags instead of GetType in operator==. - Updates unit test code to ensure flags state is part of the equality operator implementation. This resolves issue #548.
- Copies logic of GetFlags using Body accessor member functions into their non-member equivalents. - Removes GetFlags() using Body accessor member functions.
…_BOOST_UNITS enabled
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
Makes some clang-tidy suggested changes and addresses issue #549 .
Impacts/Risks of These Changes?
Code written to directly use
BodyConfmember variables likelocationandanglewill need to be updated to set these viaBodyConf::UseLocationandBodyConf::UseAngleor to get these usingGetLocation(const BodyConf&)andGetAngle(const BodyConf&).Related Issues
Issue #549.