Updates 20231020 #538
Merged
Updates 20231020 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PLAYRHO_REAL_FETCH: names a package for CMake to fetch. - PLAYRHO_REAL_GIT_REPOSITORY: specifies git repository to fetch from. - PLAYRHO_REAL_GIT_TAG: specifies tag of git sources to actually get.
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
louis-langholtz
force-pushed
the
updates-20231020
branch
from
f091017 to
6ebf8c7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
louis-langholtz
force-pushed
the
updates-20231020
branch
from
6ebf8c7 to
7d3e379
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
- Removes GetInvalid. - Enables compiling w/ realnumb external fixed point support. - Updates AlmostEqual to be more generic. - Updates AlmostEqual to use nextafter instead of epsilon. - Explicitly states in code more of the requirements on Real. Tested with: CC=/opt/homebrew/opt/llvm/bin/clang \ CXX=/opt/homebrew/opt/llvm/bin/clang++ \ LDFLAGS='-L/opt/homebrew/opt/llvm/lib/c++' \ cmake -S PlayRho -B PlayRhoBuild \ -DPLAYRHO_BUILD_UNIT_TESTS=ON \ -DPLAYRHO_BUILD_BENCHMARK=ON \ -DPLAYRHO_BUILD_TESTBED=ON \ -DPLAYRHO_BUILD_HELLOWORLD=ON \ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ -DPLAYRHO_BUILD_DOC=ON \ -DPLAYRHO_ENABLE_BOOST_UNITS=ON \ -DPLAYRHO_REAL_TYPE='::realnumb::fixed64' \ -DPLAYRHO_REAL_INCLUDE='#include <realnumb/fixed.hpp>;#include <realnumb/fixed_math.hpp>;#include <realnumb/fixed_limits.hpp>' \ -DPLAYRHO_REAL_FETCH=realnumb \ -DPLAYRHO_REAL_GIT_REPOSITORY=https://github.com/louis-langholtz/realnumb.git \ -DPLAYRHO_REAL_GIT_TAG=main \ -DPLAYRHO_INSTALL=ON \ -DREALNUMB_INSTALL=ON
louis-langholtz
force-pushed
the
updates-20231020
branch
from
7d3e379 to
5b327ac
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
PLAYRHO_REAL_FETCH: names a package for CMake to fetch.PLAYRHO_REAL_GIT_REPOSITORY: specifies git repository to fetch from.PLAYRHO_REAL_GIT_TAG: specifies tag of git sources to actually get.GetInvalid.realnumbexternal fixed point support.AlmostEqualto be more generic.AlmostEqualto usenextafterinstead of epsilon.Real.Test Info
Used the following command line invocation of CMake with these changes and confirmed compile & reasonable behavior of unit tests:
Related Issues