Updates 20231012 #536
Merged
Updates 20231012 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds some math function support for supporting Checked types. - Expands Checked constructors to behave more like its underlying value_type. - Expands Checked cast support to behave more like its underlying value_type.
- Avoids possibly effecting resulting units like when boost units enabled.
- Switches alias name of the value type from value_type to underlying_type. - Loosens conversion operator support to support any constructible conversion request even if narrowing.
louis-langholtz
added
Enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
Checkedtype to support anyis_constructible_vtype conversion instead of only non-narrowing conversions.absandnextafter) asCheckedMath.hpp.Fixed.hppin an if-statement.FixedMath.hppto keep detail functions at top and adds some new math function support fromcmath(isinfandfloor).GetCircleVerticesfrom takingunsignednumber of slices to takingstd::size_t.GetCircleVerticesto reserve space before pushing elements to avoid having to relocate memory for larger numbers of slices.