Merge pull request FRRouting#17114 from Jafaral/getenv

vtysh: fix SA warning, no need to call getenv() twice
louis-6wind · Oct 16, 2024 · 40dce0b · 40dce0b
2 parents c32bdc2 + 38661a6
commit 40dce0b
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/vtysh/vtysh_main.c b/vtysh/vtysh_main.c
@@ -350,6 +350,7 @@ int main(int argc, char **argv, char **env)
 	char pathspace[MAXPATHLEN] = "";
 	const char *histfile = NULL;
 	const char *histfile_env = getenv("VTYSH_HISTFILE");
+	const char *logpath = getenv("VTYSH_LOG");
 
 	/* SUID: drop down to calling user & go back up when needed */
 	elevuid = geteuid();
@@ -643,9 +644,7 @@ int main(int argc, char **argv, char **env)
 		}
 	}
 
-	if (getenv("VTYSH_LOG")) {
-		const char *logpath = getenv("VTYSH_LOG");
-
+	if (logpath != NULL) {
 		logfile = fopen(logpath, "a");
 		if (!logfile) {
 			fprintf(stderr, "Failed to open logfile (%s): %s\n",