Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Faraday 1.0 #194

Closed
wants to merge 1 commit into from
Closed

Fix compatibility with Faraday 1.0 #194

wants to merge 1 commit into from

Conversation

yuki24
Copy link

@yuki24 yuki24 commented Aug 25, 2019

This PR adds a build matrix for Faraday 1.0 and fixes the failing specs.

@zenspider
Copy link

This broke inspec/inspec as well. We aliased the old namespacing over to the new namespacing as a workaround. It's just a 1-liner and might be easier to swallow than this PR:

inspec/inspec@984e02e

We'd really like SOME fix to be upstream from us tho. This will start to affect more and more and Gemfiles get bumped in CIs. Especially confusing since it was faraday that bumped, not faraday_middleware.

@glaszig
Copy link

glaszig commented Dec 26, 2019

would somebody please merge/fix and release? thank you.

@bastelfreak
Copy link

Hi people. Since faraday 1.0 is out, could one of the maintainers have a look here?

@oshow
Copy link

oshow commented Jan 8, 2020

Why spec are failing:
In faraday 1.0, this env[:body] refers to request_body, because status has not yet been set here.

body = env[:body] and body.empty? && (body = nil)

@iMacTia
Copy link
Member

iMacTia commented Jan 10, 2020

I'm closing this in favour of #196 which goes for a different approach: FaradayMiddleware v1.0 will be compatible with Faraday 1.0 (I'll try to make it compatible with Faraday 0.17.x as well, but that remains to be seen

@iMacTia iMacTia closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants