Fix support for empty bodies having Content-Encoding Gzip #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
requested changes
Aug 2, 2019
There was a problem hiding this comment.
Hi @gibzon69 and thanks for raising this!
I'm surprised the decompress libraries don't manage such a simple case like this, so it's great to have Faraday addressing it!
The solution looks good, I've just left a comment about the test as I believe it should be executed for jruby as well
spec/unit/gzip_spec.rb
Outdated
| it 'removes the Content-Encoding' do | ||
| expect(process(body).headers['Content-Encoding']).to be_nil | ||
| end | ||
| end unless jruby? |
There was a problem hiding this comment.
This should be tested and work under jruby as well
There was a problem hiding this comment.
No problem. Yeah, it seems like a simple case, but I guess it doesn't happen that often.
I have removed the exception for jruby in the test now.
iMacTia
approved these changes
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes empty bodies can be received together with a Content-Encoding of, for example, "gzip". I've come across this a few times working with external API:s which send a 304 (Do not modify), together with a empty body and Content-Encoding "Gzip".
With these changes, Faraday won't raise an unknown gzip format exception, but rather just not try to decompress the body.
Example of similar fix in okhttp: square/okhttp#268