Brotli as an optional dependency for Gzip #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
Ah good point, I see what the problem is!
Thanks a lot for contributing 👍
To be honest this middleware started as a gzip decompressor but is getting more and more generic supporting other decompressors.
It would benefit from some refactoring, but I'll keep that for another day 😄.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #185
The current implementation doesn't really make
brotlioptional and the middleware will fail if it is missing and the server replies with brotli encoding.This PR should make it optional but with the current specs it is a bit difficult to test it.
optional_dependencycould be moved toFaraday::Middlewareif it makes sense later.This is just a possible solution. :)