-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship v1.0 #200
Comments
Is there an ETA on when this might be released? Is there anything I can do to help out? |
Hi John, thanks for asking - there were some API key issues re: RubyGems publishing to fully overcome, and that's being given thought. The other detail would be to fully lint the darned thing. In Faraday, we took the route of "make 1 separate Cop rule per PR" in fully linting the codebase. #203 is one such PR in this repository. We could need a RuboCop linting Issue like that, to manage the list of things already done. |
I have now marked both "enable RuboCop in CI", "lint the whole codebase" and "Move to GitHub Actions" as done. |
Perhaps one additional step: check the codebase for 2.3-ness. There were somewhat old 1.8, 1.9 compatibility fixes in here, and with the recent 2.3+ decision, we have an opportunity to remove them. |
👍 for removing tec debt, but would be nice to be able to use faraday 1.0 :) maybe this can be postponed to v1.0.1? |
As a status report, there's now a 1.0.0.rc1 to try out. |
Everyone's feedback would be extremely appreciated if you had any low-risk project you could try this out in combination with Faraday 0.x and 1.0. Thank you! |
This is now done 🎉! |
After merging #196,
master
branch should be compatible with Faraday 1.0, however before shipping a 1.0 release we might want to do also the following:The text was updated successfully, but these errors were encountered: