Improve streaming interface to provide response info #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
force-pushed
the
mg/response-streaming-interface
branch
2 times, most recently
from
8b67414 to
b306082
Compare
iMacTia
force-pushed
the
mg/response-streaming-interface
branch
from
b306082 to
f3290e2
Compare
* Backwards-compatible * Allow adapters to provide response info to on_call block * Provide `stream_response` helper method
* Make `truffleruby-head` experimental * Add `ruby-head` as experimental
iMacTia
force-pushed
the
mg/response-streaming-interface
branch
from
fd622e8 to
e1604b0
Compare
olleolleolle
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Thanks @iMacTia!
The TODOs are good, they work as a sign-post.
|
I'd forget about documentation all the time without it 😂 |
iMacTia
added a commit
that referenced
this pull request
Aug 8, 2022
* Backwards-compatible * Allow adapters to provide response info to on_call block * Provide `stream_response` helper method
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bake-test-externaland testfaraday-net_httpas part of the CIstream_responsehelperFixes #1426
Todos
List any remaining work that needs to be done, i.e:
Additional Notes
faraday-net_httptests as part of CI thanks to bake-test-external 🙌bake-test-externalis incompatible with Ruby 2.6, so we only run them for Ruby 2.7+truffleruby-headandruby-headare back in the CI matrix, but they've been marked as experimental