Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix test adapter thread safety.
This is a follow-up attempt from #1379
Fixes #1365
Additional Notes
Tested locally using "Steps to reproduce" from #1365.
Below are the benchmark results:
The change does, as expected, slow down the test adapter, but this doesn't seem to be too much (~ 24%).
Considering this is mostly used in test environments rather than production ones, it should be safe to have a small dip in performance. It's also worth noting that this only applies to a multi-threaded environment.
Most applications will use the test adapter in a single thread and normally recreate the connection for each test example, so there would be no performance impact in that scenario