Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC fix text on null hypothesis in quantile example #126

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

lorentzenchr
Copy link
Owner

No description provided.

@lorentzenchr
Copy link
Owner Author

@m-maggi Do you want to review this one?

@lorentzenchr lorentzenchr merged commit 71c6b8d into main Dec 8, 2023
@lorentzenchr lorentzenchr deleted the ttest_example branch December 8, 2023 18:37
@m-maggi
Copy link
Contributor

m-maggi commented Dec 8, 2023

@lorentzenchr sorry, I am new to code reviews on github and my comment stayed with a label „pending“. I‘ll try now to submit my comment

@lorentzenchr
Copy link
Owner Author

At the top right, there is a green button "review changes". If you click, you can select "comment", "approve" and "request changes". I usually only use one of the first 2 choices.

Copy link
Contributor

@m-maggi m-maggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorentzenchr this was my only comment which I left by mistake pending

@@ -451,7 +451,8 @@
"metadata": {},
"source": [
"The test statistic is negative which means that the score of the linear model is better than the one of the true quantile.\n",
"The very large p-value, however, leaves us no room but to reject the null hypothesis of equal mean values, i.e. equal scores.\n",
"With the very large p-value, however, we cannot reject the null hypothesis of equal mean values, i.e. equal scores.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have to figure out how I can propose a change as part of the review.
In this case I would make more explicit the "equal mean values" by changing to "equal mean score values" since we are talking about E(S(m(X),Y)) following the notation of 5.1.4 https://arxiv.org/pdf/2202.12780.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants