Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build solution because of misconfigured mbedtls dependency #142

Closed
danigian opened this issue Jan 6, 2022 · 3 comments
Closed

Can't build solution because of misconfigured mbedtls dependency #142

danigian opened this issue Jan 6, 2022 · 3 comments

Comments

@danigian
Copy link

danigian commented Jan 6, 2022

When trying to build the basic station binaries, a failure in cloning from mbedtls dependency is happening.

mkdir -p build-local/bin

gcc -std=gnu11 -Isrc -DCFG_prog_crc32 src/crc32.c -o build-local/bin/crc32

mkdir -p build-local/bin

gcc -std=gnu11 -Isrc -DCFG_prog_genkwcrcs src/genkwcrcs.c -o build-local/bin/genkwcrcs

build-local/bin/genkwcrcs $(cat src/kwlist.txt | sed -e '/^#/d;s/[ \t]\+#.*//') > build-local/temp-kwcrc.h

mv build-local/temp-kwcrc.h src/kwcrc.h

platform=linux variant=std make -C deps/mbedtls

make[1]: Entering directory '/basicstation/deps/mbedtls'

platform=linux variant=std ./prep.sh

Cloning into 'git-repo'...

warning: Could not find remote branch mbedtls-2.6 to clone.

fatal: Remote branch mbedtls-2.6 not found in upstream origin

make[1]: *** [makefile:55: platform-linux] Error 128

make[1]: Leaving directory '/basicstation/deps/mbedtls'

The reason for this is a rename in mbedtls repository that moved branch mbedtls-2.6 to archive/mbedtls-2.6

I created #143 which fixes this issue.

@beitler
Copy link
Contributor

beitler commented Jan 6, 2022

Hi @danigian,

thanks a lot for bringing this to our attention. While your PR is indeed an acceptable work around for this issue, unfortunately I will not be able to merge it at this time.
We are working on a solution and will update the repo in due course.

Thanks again!

@beitler beitler closed this as completed in 6675c77 Jan 6, 2022
@danigian
Copy link
Author

danigian commented Jan 6, 2022

@beitler I see you fixed the issue. Do you also have any plan to recreate v2.0.5 tag with the fix (or release v2.0.6)?

@beitler
Copy link
Contributor

beitler commented Jan 6, 2022

The tagged release v2.0.5 will stay as it is.
We are planning to push the next tagged release v2.0.6 with numerous more fixes within a few weeks.

mpous added a commit to mpous/basicstation that referenced this issue Jan 13, 2022
mpous added a commit to mpous/basicstation that referenced this issue Jan 13, 2022
Update mbedTLS dependency to version 2.7.5. Related to lorabasics#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants