Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing nil err check #76

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add missing nil err check #76

merged 1 commit into from
Feb 5, 2025

Conversation

pojntfx
Copy link
Member

@pojntfx pojntfx commented Feb 5, 2025

During S3 migrations we compare an err value to an error without checking if that err is nil first. This PR fixes that.

@pojntfx
fix: Don't panic when checking if an error is errNoSuchKey and `e…
082bb38 
…rr` is `nil`

Signed-off-by: Felicitas Pojtinger <felicitas@pojtinger.com>
@pojntfx pojntfx requested a review from jimmyaxod February 5, 2025 05:27
@pojntfx pojntfx self-assigned this Feb 5, 2025
@pojntfx pojntfx mentioned this pull request Feb 5, 2025
Merged
jimmyaxod
jimmyaxod approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@jimmyaxod jimmyaxod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pojntfx pojntfx merged commit 52cdcfa into main Feb 5, 2025
4 checks passed
@pojntfx pojntfx deleted the fix-err-nil-check branch February 5, 2025 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimmyaxod jimmyaxod jimmyaxod approved these changes

Assignees

@pojntfx pojntfx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pojntfx @jimmyaxod