Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle enum #10065

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: handle enum #10065

merged 1 commit into from
Nov 21, 2023

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Oct 17, 2023 •
edited
Loading

lb4 discover doesn't handle enum properly. This PR implements this workaround for the enum in lb4 discover.

Related GitHub issues & PRs:

PR loopbackio/loopback-connector-mysql#525

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@aaqilniz
fix: handle enum
866390a 
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
@aaqilniz aaqilniz marked this pull request as ready for review November 3, 2023 15:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6747094491

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.05%
Totals Coverage Status
Change from base Build 6737596426: 0.0%
Covered Lines: 9560
Relevant Lines: 12445
💛 - Coveralls

@aaqilniz aaqilniz mentioned this pull request Nov 4, 2023
Merged
5 tasks
@aaqilniz
Copy link
Contributor Author

aaqilniz commented Nov 4, 2023

Hi, @dhmlau. Can you please have a look at this PR and the related PR?

@aaqilniz
Copy link
Contributor Author

Hi, @achrinza. Can you please have a look at this PR related to the PR at MySQL connector.

@samarpanB samarpanB merged commit f664a76 into loopbackio:master Nov 21, 2023
13 checks passed
@aaqilniz aaqilniz deleted the fix/enum-handling branch April 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpanB samarpanB samarpanB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaqilniz @coveralls @samarpanB