Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add change / delete events #65

Merged
merged 2 commits into from
Jan 30, 2014
Merged

Add change / delete events #65

merged 2 commits into from
Jan 30, 2014

Conversation

ritch
Copy link
Contributor

@ritch ritch commented Jan 28, 2014

Add events for hooking into model changes.

/to @raymondfeng

@slnode
Copy link

slnode commented Jan 28, 2014

Test PASSed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback-datasource-juggler/266/

@bajtos
Copy link
Member

bajtos commented Jan 29, 2014

There are no unit-tests for the new events, is it intentional?

@ritch
Copy link
Contributor Author

ritch commented Jan 29, 2014

Nope. Adding tests.

@slnode
Copy link

slnode commented Jan 29, 2014

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback-datasource-juggler/274/

@ritch
Copy link
Contributor Author

ritch commented Jan 29, 2014

test please

@slnode
Copy link

slnode commented Jan 29, 2014

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback-datasource-juggler/276/

@ritch
Copy link
Contributor Author

ritch commented Jan 30, 2014

test please

@slnode
Copy link

slnode commented Jan 30, 2014

Test PASSed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback-datasource-juggler/285/

@raymondfeng
Copy link
Contributor

LGTM

ritch added a commit that referenced this pull request Jan 30, 2014
@ritch
Merge pull request #65 from strongloop/feature/change-hook
61a54da 
Add change / delete events
@ritch ritch merged commit 61a54da into master Jan 30, 2014
@ritch ritch deleted the feature/change-hook branch January 30, 2014 21:54
@clark0x
Copy link
Contributor

clark0x commented Dec 11, 2014

Why create() and updateAttributes() emit same event? is it intentional?

I expect that create() emits created, and updateAttributes() emits updated, etc.

@clark0x clark0x mentioned this pull request Dec 12, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ritch @slnode @bajtos @raymondfeng @clark0x