✨ Add support to query encrypted data #479

SAMIBETTAYEB · 2021-06-17T22:33:05Z

New feature about querying encrypted fields.

slnode · 2021-06-17T22:33:12Z

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

dhmlau

@SAMIBETTAYEB, thanks for the PR. Could you please add some tests to verify your changes? Also, please sign the DCO as well. Thanks!

dhmlau · 2021-06-21T17:32:42Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "loopback-connector-postgresql",
-  "version": "3.9.1",
+  "version": "3.10.0",


there's no need for this change. When we publish a new version, the tool will update it for us.

dhmlau · 2021-06-21T17:34:37Z

You can sign the DCO by running the following command:

git commit --amend -s

Reference: https://loopback.io/doc/en/contrib/code-contrib.html.

stale · 2021-08-21T22:28:39Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SAMIBETTAYEB · 2021-09-01T16:28:50Z

Do any of the reviewers verify it, please?

achrinza · 2021-09-02T04:03:59Z

Hi @sam-github, could you rebase your PR against the latest copy of master? That way the CI pipeline can be triggered.

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Seems like syntax error: - autoupdate not working due to variable is unset - without this change (just comment this line) Indexes was not updated Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

* chore: set package-lock=false in .npmrc (Aidan Harbison) * Extends test structure to cover fix (Viktor Shanin) * Fix Index upgrade (Viktor Shanin) * fix: jsdoc (loopbackio#385) (Janny) * Enable Travis CI integration (Miroslav Bajtoš) * Manually fix remaining linting violations (Miroslav Bajtoš) * Auto-fix linting violations (Miroslav Bajtoš) * Update eslint to ^6.0.1 (Miroslav Bajtoš) * Update dev-dependencies (Miroslav Bajtoš) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Run `eslint --fix .` to add trailing commas to function arguments. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Rapidly-fired queries can exhaust the pool capability and lead to odd results. In test, we've witnessed "Connection Terminated" flakiness with many fast test suites. This, combined with setting `lazyConnect: true` and `idleTimeoutMillis: 0`, alleviates the issue. Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

* fix(pool): synchronously release pool connection (Samuel Reed) * Handler for with(out) time zone time(stamp) types (Stefano Pirra) * chore: improve issue and PR templates (Nora) * chore: exclude "good first issues" from stalebot (Miroslav Bajtoš) * Fix eslint violations (Miroslav Bajtoš) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Array properties are represented as juggler `List` instance, we need to modify test assertions to convert them via `toArray()` before applying `.should.eql` check. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

* test: clean test for `contains` operator (Miroslav Bajtoš) * test: fix array tests to handle List values (Miroslav Bajtoš) * docs: improve README organization (Miroslav Bajtoš) * feat: adds 'contains' operator for querying arrays (shubhisood) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: Raymond Feng <enjoyjava@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

* Ensure order of and/or clauses are preserved (Raymond Feng) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: Matthew Gabeler-Lee <mgabeler-lee@6river.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

* fix: enable pool error handling (Matthew Gabeler-Lee) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: Francisco Buceta <frbuceta@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

This reverts commit e3ba700. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: Agnes Lin <agneslin.lin@ibm.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

* Add on delete options on FK constraints (Quentin Le Bour) * ci: switch from Travis to Github Actions (Agnes Lin) * Revert "ci: switch travis to github actions" (Miroslav Bajtoš) * ci: switch travis to github actions (Francisco Buceta) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

When `PostgreSQL.prototype.getDropForeignKeys` gets called with duplicated foreign keys, an invalid `ALTER TABLE` statement gets created. This is because the duplicates are mapped to multiple `DROP CONSTRAINT fk_key` SQL actions, e.g.: ```sql -- This will throw an error ALTER TABLE "public"."foo" DROP CONSTRAINT "fk_duplicatedKey", DROP CONSTRAINT "fk_duplicatedKey", DROP CONSTRAINT "fk_duplicatedKey", DROP CONSTRAINT "fk_otherKey" ``` As the `DROP CONSTRAINT` actions are run sequentially, when the first action gets executed by PostgreSQL, the next one (for the same, but already dropped key) will not cause an SQL error thanks to the added IF EXISTS check: ```sql -- This is valid SQL ALTER TABLE "public"."foo" DROP CONSTRAINT IF EXISTS "fk_duplicatedKey", DROP CONSTRAINT IF EXISTS "fk_duplicatedKey", DROP CONSTRAINT IF EXISTS "fk_duplicatedKey", DROP CONSTRAINT IF EXISTS "fk_otherKey" ``` Please note, this is really a hack and we still need to understand why the method in question gets called with duplicated foreign keys in certain conditions. Signed-off-by: Chris Kobrzak <chris.kobrzak@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: Diana Lau <dhmlau@ca.ibm.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

SAMIBETTAYEB · 2021-09-02T14:24:06Z

@achrinza, done!

SAMIBETTAYEB · 2021-09-07T16:50:49Z

Can any of the reviewers verify the PR, please?

achrinza · 2021-09-12T14:37:58Z

Apologies @SAMIBETTAYEB, I didn't realise that this PR was targeting 3.x instead of master. I'll cherry-pick the commits into new PRs.

SAMIBETTAYEB · 2021-09-12T14:45:21Z

Thank you @achrinza, waiting for your review.

achrinza · 2021-09-12T15:42:12Z

Thanks, @SAMIBETTAYEB; Would you be able to point this PR to the master branch (v5.x)? Or is 3.x necessary? Based on what I can tell, 5.x supports both LB3 and LB4.

SAMIBETTAYEB · 2021-09-12T15:53:51Z

Yep @achrinza, I think it will be.

achrinza · 2021-09-12T16:09:49Z

Thanks, @SAMIBETTAYEB. If you're comfortable with performing this, could you please reset the branch against master, then cherry-pick the commit range you intend to submit?

The commands should look similar to this:

$ git reset --hard upstream/master # Assuming you've set `upstream` remote to loopbackio/loopback-connector-postgresql
$ git cherry-pick 1199248a0a3e2881241e01d970bb1411605bfead...9beef0c353f335731e498fe262f6daac50012103

# Fix any merge conflicts
git add --all
git cherry-pick --continue
# Repeat last 2 steps for each commit with a merge conflict

# Push changes to remote
$ git push --force-with-lease

Please adjust the commands above according to your Git setup if necessary.

For a wrost-case scenario, I've created a 'backup' of your original commits at #486

stale · 2021-11-11T16:14:42Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SAMIBETTAYEB requested review from agnes512, dhmlau, emonddr and jannyHou as code owners June 17, 2021 22:33

SAMIBETTAYEB force-pushed the development branch 2 times, most recently from 32b572b to 001a9d9 Compare June 18, 2021 10:30

dhmlau reviewed Jun 21, 2021

View reviewed changes

SAMIBETTAYEB force-pushed the development branch 4 times, most recently from ba6206a to e795527 Compare June 22, 2021 21:00

stale bot added the stale label Aug 21, 2021

stale bot removed the stale label Sep 1, 2021

SAMIBETTAYEB force-pushed the development branch from 2a7973e to 3ce7d86 Compare September 2, 2021 14:19

jannyHou and others added 11 commits September 2, 2021 15:20

fix: jsdoc (loopbackio#385)

1c43c9f

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

chore: set package-lock=false in .npmrc

871374d

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Fix Index upgrade

9fb6c85

Seems like syntax error: - autoupdate not working due to variable is unset - without this change (just comment this line) Indexes was not updated Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Extends test structure to cover fix

8f8b2c7

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

chore: exclude "good first issues" from stalebot

036e01d

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Fix eslint violations

cfd069b

Run `eslint --fix .` to add trailing commas to function arguments. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

chore: improve issue and PR templates

f4ed37f

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Handler for with(out) time zone time(stamp) types

a7a538a

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

bajtos and others added 20 commits September 2, 2021 15:20

test: clean test for contains operator

4b434bc

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Ensure order of and/or clauses are preserved

0edc558

Signed-off-by: Raymond Feng <enjoyjava@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

5.2.1

26e2a73

* Ensure order of and/or clauses are preserved (Raymond Feng) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

fix: enable pool error handling

7d2ba32

Signed-off-by: Matthew Gabeler-Lee <mgabeler-lee@6river.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

5.3.0

98df623

* fix: enable pool error handling (Matthew Gabeler-Lee) Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

ci: switch travis to github actions

09ed542

Signed-off-by: Francisco Buceta <frbuceta@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Revert "ci: switch travis to github actions"

9902bee

This reverts commit e3ba700. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

ci: switch from Travis to Github Actions

cb5cee0

Signed-off-by: Agnes Lin <agneslin.lin@ibm.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

Add on delete options on FK constraints

33de0e2

Signed-off-by: Agnes Lin <agneslin.lin@ibm.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

chore: move repo to loopbackio org

2994e4e

Signed-off-by: Diana Lau <dhmlau@ca.ibm.com> Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

✨ Add support to query encrypted data

1199248

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

⬆️ Add dev dependencies

8899f59

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

🗃 Enable pgcrypto extension

c1a2074

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

🔧 Add required crypto env variables

81dfaec

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

✅ 🗃 Add encrypted_data table for testing purposes

b4ff5e7

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

✨ ✅ Add encrypted data tests

9beef0c

Signed-off-by: SAMI BETTAYEB <sami3639@gmail.com>

SAMIBETTAYEB force-pushed the development branch from 3ce7d86 to 9beef0c Compare September 2, 2021 14:22

stale bot added the stale label Nov 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add support to query encrypted data #479

✨ Add support to query encrypted data #479

SAMIBETTAYEB commented Jun 17, 2021

slnode commented Jun 17, 2021

dhmlau left a comment

dhmlau Jun 21, 2021

SAMIBETTAYEB Jun 22, 2021

dhmlau commented Jun 21, 2021

stale bot commented Aug 21, 2021

SAMIBETTAYEB commented Sep 1, 2021

achrinza commented Sep 2, 2021

SAMIBETTAYEB commented Sep 2, 2021

SAMIBETTAYEB commented Sep 7, 2021

achrinza commented Sep 12, 2021

SAMIBETTAYEB commented Sep 12, 2021

achrinza commented Sep 12, 2021 •

edited

Loading

SAMIBETTAYEB commented Sep 12, 2021

achrinza commented Sep 12, 2021 •

edited

Loading

stale bot commented Nov 11, 2021

✨ Add support to query encrypted data #479

Are you sure you want to change the base?

✨ Add support to query encrypted data #479

Conversation

SAMIBETTAYEB commented Jun 17, 2021

slnode commented Jun 17, 2021

dhmlau left a comment

Choose a reason for hiding this comment

dhmlau Jun 21, 2021

Choose a reason for hiding this comment

SAMIBETTAYEB Jun 22, 2021

Choose a reason for hiding this comment

dhmlau commented Jun 21, 2021

stale bot commented Aug 21, 2021

SAMIBETTAYEB commented Sep 1, 2021

achrinza commented Sep 2, 2021

SAMIBETTAYEB commented Sep 2, 2021

SAMIBETTAYEB commented Sep 7, 2021

achrinza commented Sep 12, 2021

SAMIBETTAYEB commented Sep 12, 2021

achrinza commented Sep 12, 2021 • edited Loading

SAMIBETTAYEB commented Sep 12, 2021

achrinza commented Sep 12, 2021 • edited Loading

stale bot commented Nov 11, 2021

achrinza commented Sep 12, 2021 •

edited

Loading

achrinza commented Sep 12, 2021 •

edited

Loading