Add docs on numeric data type #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0candy
approved these changes
Jun 22, 2017
dhmlau
reviewed
Jun 23, 2017
README.md
Outdated
|
|
||
| **Note**: Please be advised the [node.js driver for postgres](https://github.com/brianc/node-postgres) by default casts `Numeric` type as a string on `GET` operation. This is to avoid _data precision loss_ since `Numeric` types in postgres cannot be safely converted to JavaScript `Number`. | ||
|
|
||
| [Link to the corresponding driver issue](https://github.com/brianc/node-pg-types/issues/28). |
There was a problem hiding this comment.
maybe "For details, see the corresponding driver issue"?
README.md
Outdated
| @@ -363,6 +363,12 @@ See [LoopBack types](http://loopback.io/doc/en/lb3/LoopBack-types.html) for de | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| ## Numeric Data Type | |||
|
|
|||
| **Note**: Please be advised the [node.js driver for postgres](https://github.com/brianc/node-postgres) by default casts `Numeric` type as a string on `GET` operation. This is to avoid _data precision loss_ since `Numeric` types in postgres cannot be safely converted to JavaScript `Number`. | |||
There was a problem hiding this comment.
I don't think we need the "please be advised".. but I'm not english expert :)
ssh24
force-pushed
the
add-docs-on-numeric-type
branch
from
8408763 to
cdf51c3
Compare
dhmlau
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The node.js driver for postgres returns a
Numerictype value as a string to avoid data precision loss. Since we as the ORM simply just return back the result from the driver, we need to document this behaviour.connect to #58