fix: Set deffault max label format if undefined. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjmg
reviewed
Oct 2, 2023
src/functions.js
Outdated
There was a problem hiding this comment.
Can we please name this module as something that explains what the functions within the file do?
yesudeep
reviewed
Oct 2, 2023
src/tests/viz-gauge.test.js
Outdated
|
|
||
| describe('Should process data and return a chunk with needed configurations', () => { | ||
| test('should return all needed properties', () => { | ||
| var chunk = processData(testData, testQueryResponse, testConfig, undefined); |
There was a problem hiding this comment.
please use const and let over using var.
|
LGTM |
elivillalejos
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-09-17) ### Features * add additional tests ([#10](#10)) ([4f23b8c](4f23b8c)) * add basic infrastructure to organize, format, and test the code. ([ee5605e](ee5605e)) * Adds implementation for CI ([#20](#20)) ([2a0ea8e](2a0ea8e)) * use pnpm to build our binaries ([4f23b8c](4f23b8c)) ### Bug Fixes * ensure bootstrap works on distros with apt as the package manager ([4f23b8c](4f23b8c)) * Failing unit tests ([4f23b8c](4f23b8c)) * Set deffault max label format if undefined. ([#5](#5)) ([255969e](255969e)) * Updated build ([4f23b8c](4f23b8c)) * upgrades styled-components to latest version to remove @babel/traverse vulnerability ([#23](#23)) ([1945b7e](1945b7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.