Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed do not have the "copy contents" button #490

Closed
bjufre opened this issue Jun 22, 2023 · 4 comments
Closed

Embed do not have the "copy contents" button #490

bjufre opened this issue Jun 22, 2023 · 4 comments
Labels
feature request A suggestion for a feature or enhancement v2.x Issues/PRs that affect the v2.x line of releases

Comments

@bjufre
Copy link

bjufre commented Jun 22, 2023

Describe the bug

I'm building a custom documentation site for our design system, and in order to take advantage of Lookbook we're using previews with the source panel. And we're successful in adding them to the page with no issues. Except for the fact that the action/button for copying the contents is no added.

This is important for the easy adaptation of the design system within the company. I know it's not a huge stopper, but I think it makes things a little more convenient.

To Reproduce

Steps to reproduce the behavior:

  1. Create a preview
  2. Go to the normal Lookbook site
  3. Then add an embed somewhere of the same preview
  4. The copy button is not added in the embed (see images)

Expected behavior

The copy button is also added or at least there's the option to add it.

Screenshots

Lookbook page:
CleanShot 2023-06-22 at 07 32 47@2x

Embed:
CleanShot 2023-06-22 at 07 33 26@2x

Version numbers

Please complete the following information:

  • Lookbook: v2.0.4
  • ViewComponent: 3.1.0
  • Rails: 7
  • Ruby: 2.7.8
@bjufre bjufre added the bug Something isn't working label Jun 22, 2023
@allmarkedup
Copy link
Collaborator

Hey @bjufre - sorry for the slow reply! You are totally right, the embeds should definitely include the copy buttons. I haven't had a lot of time to spend on Lookbook recently but this should be a relatively quick thing to add so I'll try to get it done as soon as I get a chance.

Thanks for bringing it to my attention :)

@allmarkedup allmarkedup added v2.x Issues/PRs that affect the v2.x line of releases feature request A suggestion for a feature or enhancement and removed bug Something isn't working labels Jul 6, 2023
@bjufre
Copy link
Author

bjufre commented Jul 7, 2023

@allmarkedup thank you very muuuch!!

@allmarkedup
Copy link
Collaborator

Hey @bjufre - so sorry this has taken so long but I've just released v2.1.0 that includes the addition of a code copy button in embeds. So I'll close this down now but let me know if you run into any issues with it :)

@bjufre
Copy link
Author

bjufre commented Sep 25, 2023

@allmarkedup thank you very much for the update! No worries I understand! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A suggestion for a feature or enhancement v2.x Issues/PRs that affect the v2.x line of releases
Projects
None yet
Development

No branches or pull requests

2 participants