Merge pull request #503 from natematykiewicz/disable_reload_in_produc…

…tion Disable code reloading in production by default
lookbook-hq · Aug 30, 2023 · f947d67 · f947d67
2 parents 3845215 + 0c48855
commit f947d67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/docs/src/_data/config_options.yml b/docs/src/_data/config_options.yml
@@ -223,10 +223,10 @@ debugging:
 system:
   - name: reload_on_change
     types: Boolean
-    default: "config.reload_classes_only_on_change"
+    default: "!config.cache_classes && config.reload_classes_only_on_change"
     example: config.lookbook.reload_on_change = true
     description: |
-      By default Lookbook uses the value of the `reload_classes_only_on_change` Rails config option to decide if
+      By default Lookbook uses the value of the `cache_classes` and `reload_classes_only_on_change` Rails config options to decide if
       it should attempt to update the preview data after changes. If set the value of this config option will take precedence and be used instead.
 
   - name: live_updates

diff --git a/lib/lookbook/engine.rb b/lib/lookbook/engine.rb
@@ -62,7 +62,9 @@ class Engine < Rails::Engine
         ViewComponent::Preview.extend(Lookbook::PreviewAfterRender)
       end
 
-      opts.reload_on_change = host_config.reload_classes_only_on_change if opts.reload_on_change.nil?
+      if opts.reload_on_change.nil?
+        opts.reload_on_change = !host_config.cache_classes && host_config.reload_classes_only_on_change
+      end
     end
 
     config.after_initialize do