Support text sticker line break #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longitachi
reviewed
Oct 24, 2022
| @@ -213,7 +214,7 @@ extension ZLInputTextViewController: UICollectionViewDelegate, UICollectionViewD | |||
|
|
|||
| extension ZLInputTextViewController: UITextViewDelegate { | |||
| func textView(_ textView: UITextView, shouldChangeTextIn range: NSRange, replacementText text: String) -> Bool { | |||
| if text == "\n" { | |||
| if !ZLImageEditorConfiguration.default().textStickerCanLineBreak && text == "\n" { | |||
There was a problem hiding this comment.
I think the newlines of the text should be trimmed before the callback in the doneBtnClick method.
There was a problem hiding this comment.
@longitachi Thanks all for the lighting fast response! I fixed that in the doneBtnClick by textView.text = textView.text.trimmingCharacters(in: .whitespacesAndNewlines).
longitachi
approved these changes
Oct 26, 2022
|
@longitachi Thank you for your review and merge. Can I create a pull request for bump up version to 1.1.5? |
|
@darquro I will release v1.1.5 later. |
|
Done. |
|
@longitachi Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @longitachi,
My app's customer requests input line break on text sticker.
So I added new configuration
textStickerCanLineBreak.I'm appreciate if you would review this proposal.
Thank you.