Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(integration): refine test_upgrade #2360

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(integration): refine test_upgrade #2360

wants to merge 1 commit into from

Conversation

chriscchien
Copy link
Contributor

@chriscchien chriscchien commented Mar 10, 2025 •
edited
Loading

Which issue(s) this PR fixes:

Issue #10539

What this PR does / why we need it:

Refine test_upgrade, add belwo CRs before Longhorn upgrade

Add below CRs into test case test_upgrade no matter the value of environment RUN_V2_TEST is:

  1. Install Stable Version

    • v1 volume, never attached before upgrade
    • v1 volume with data, detached before upgrade
    • If stable version >= v1.8:
      • v2 volume, never attached before upgrade
      • v2 volume with data, detached before upgrade
      • dynamically provisioned v2 volume with deployment
      • v2 backing image
      • v2 volume backup

  2. Install Transient Version (if available)

  3. Install Test Version

    • Attach all volumes created before the upgrade and check data
    • v2 volume replica rebuilding
    • Restore v2 backup

Special notes for your reviewer:

N/A

Additional documentation or context

N/A

@chriscchien chriscchien self-assigned this Mar 10, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chriscchien chriscchien force-pushed the update_upgrade branch 4 times, most recently from 7bf42f6 to e8856e7 Compare March 10, 2025 12:44
roger-ryao
roger-ryao reviewed Mar 11, 2025
View reviewed changes
manager/integration/tests/test_upgrade.py Outdated

vol_detached_v2 = client.by_id_volume(vol_detached_v2_name)
vol_detached_v2.attach(hostId=host_id)
vol_detached_v2 = wait_for_volume_healthy(client, vol_detached_v2_name)
Copy link
Contributor

@roger-ryao roger-ryao Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to these three issues:
Issue #10461
Issue #10131
Issue #10053
I believe v2 volume attach test can only be applied to versions after 1.9.x and is not suitable for versions prior to 1.8.x.

The v2 volume attach test test steps should only be applicable for the following upgrade scenarios:

  • Upgrading from 1.8.1 to 1.8.x
  • Upgrading to 1.9.x or later.
    Testing cannot proceed for upgrades from 1.7.x to 1.8.x.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have implemented this part in local, will update after my local test complete.

@chriscchien chriscchien force-pushed the update_upgrade branch 3 times, most recently from 24c388d to fd8bb89 Compare March 12, 2025 11:26
@chriscchien
test(integration): refine test_upgrade
6e7c254 
ref: longhorn/longhorn 10539

Signed-off-by: Chris Chien <chris.chien@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger-ryao roger-ryao roger-ryao left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@chriscchien chriscchien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscchien @roger-ryao