Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vendor): pin k8s libs to 0.28.5 #95

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented Dec 16, 2024

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

  • v1.6.x is using k8s libs 0.28.5
  • v1.6.x and v1.7.x is using go 1.22

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit requested a review from innobead December 16, 2024 07:07
@derekbit derekbit self-assigned this Dec 16, 2024
Copy link

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (300)
  • go.mod is excluded by !go.mod
  • go.sum is excluded by !**/*.sum, !go.sum
  • vendor/github.com/evanphx/json-patch/.gitignore is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/LICENSE is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/README.md is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/errors.go is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/merge.go is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/patch.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/.gitignore is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/.golangci.yml is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/CODE_OF_CONDUCT.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/CONTRIBUTING.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/LICENSE is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/README.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/SECURITY.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/bytestring.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/cache.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/common.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/decode.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/diagnose.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/doc.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode_map.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode_map_go117.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/simplevalue.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/stream.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/structfields.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/tag.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/valid.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns_linux.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns_linux_fuzzer.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns_unsupported.go is excluded by !vendor/**
  • vendor/github.com/x448/float16/.travis.yml is excluded by !vendor/**
  • vendor/github.com/x448/float16/README.md is excluded by !vendor/**
  • vendor/github.com/x448/float16/float16.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/.travis.yml is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/LICENSE is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/LICENSE.libyaml is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/NOTICE is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/README.md is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/apic.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/decode.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/emitterc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/encode.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/parserc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/readerc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/resolve.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/scannerc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/sorter.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/writerc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/yaml.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/yamlh.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/yamlprivateh.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apiserverinternal/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apps/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authentication/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authentication/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authentication/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authorization/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/batch/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/batch/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/coordination/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/annotation_key_constants.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/core/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/objectreference.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/discovery/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/events/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/events/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/well_known_labels.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/node/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/node/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/node/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/policy/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/rbac/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/rbac/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/rbac/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha3/doc.go is excluded by !vendor/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces a debug logging statement in the getSystemBlockDeviceInfo function within the sys/sys.go file. The new log entry uses the Logrus logging library to print the parsed device numbers, which can help developers trace and understand the values being processed during system block device information retrieval.

Changes

File Change Summary
sys/sys.go Added a debug logging statement using logrus.Infof() to log device numbers in the getSystemBlockDeviceInfo function

Note: This change is purely for debugging purposes and does not modify the function's core logic or behavior.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@c3y1huang c3y1huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this change. Does this imply that the go-common-lib must always align with the version used in the minimum actively supported Longhorn version? If so, could this potentially become a blocker for updating Kubernetes
or other dependencies?

@derekbit derekbit force-pushed the pin branch 2 times, most recently from da5e018 to 11e0f79 Compare December 16, 2024 07:47
@derekbit derekbit changed the title chore(vendor): pin k8s libs to 0.28.5 and go to 1.22 chore(vendor): pin k8s libs to 0.28.5 Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (96d5048) to head (2ecfaf4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   77.25%   77.30%   +0.04%     
==========================================
  Files          37       37              
  Lines        2071     2071              
==========================================
+ Hits         1600     1601       +1     
+ Misses        342      341       -1     
  Partials      129      129              
Flag Coverage Δ
unittests 77.30% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekbit derekbit marked this pull request as ready for review December 16, 2024 07:56
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
sys/sys.go (1)

Line range hint 115-122: Enhance error context for debugging

The debug log could be more helpful if it preserved context for error cases. Consider moving the logging to include both success and error scenarios.

 numbers := strings.Split(strings.TrimSpace(string(data)), ":")
-logrus.Infof("Debug ========> %v", numbers)
 major, err := readDeviceNumber(numbers, 0)
 if err != nil {
+    logrus.WithFields(logrus.Fields{
+        "deviceName": deviceName,
+        "numbers": numbers,
+        "error": err,
+    }).Debug("Failed to parse major device number")
     logrus.WithError(err).Warnf("failed to read device %s major", deviceName)
     continue
 }
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96d5048 and 11e0f79.

⛔ Files ignored due to path filters (299)
  • go.mod is excluded by !go.mod
  • go.sum is excluded by !**/*.sum, !go.sum
  • vendor/github.com/evanphx/json-patch/.gitignore is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/LICENSE is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/README.md is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/errors.go is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/merge.go is excluded by !vendor/**
  • vendor/github.com/evanphx/json-patch/patch.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/.gitignore is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/.golangci.yml is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/CODE_OF_CONDUCT.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/CONTRIBUTING.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/LICENSE is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/README.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/SECURITY.md is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/bytestring.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/cache.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/common.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/decode.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/diagnose.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/doc.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode_map.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/encode_map_go117.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/simplevalue.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/stream.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/structfields.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/tag.go is excluded by !vendor/**
  • vendor/github.com/fxamacker/cbor/v2/valid.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns_linux.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns_linux_fuzzer.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/userns/userns_unsupported.go is excluded by !vendor/**
  • vendor/github.com/x448/float16/.travis.yml is excluded by !vendor/**
  • vendor/github.com/x448/float16/README.md is excluded by !vendor/**
  • vendor/github.com/x448/float16/float16.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/.travis.yml is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/LICENSE is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/LICENSE.libyaml is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/NOTICE is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/README.md is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/apic.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/decode.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/emitterc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/encode.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/parserc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/readerc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/resolve.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/scannerc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/sorter.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/writerc.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/yaml.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/yamlh.go is excluded by !vendor/**
  • vendor/gopkg.in/yaml.v2/yamlprivateh.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apidiscovery/v2beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apiserverinternal/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apps/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/apps/v1beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authentication/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authentication/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authentication/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authentication/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authorization/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/authorization/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/autoscaling/v2beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/batch/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/batch/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/batch/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/certificates/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/certificates/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/coordination/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1alpha2/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/coordination/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/annotation_key_constants.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/core/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/objectreference.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/core/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/discovery/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/discovery/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/events/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/events/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/events/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/extensions/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/flowcontrol/v1beta3/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/imagepolicy/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1alpha1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/well_known_labels.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/networking/v1beta1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/node/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/node/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/node/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/node/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/policy/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/zz_generated.deepcopy.go is excluded by !vendor/**
  • vendor/k8s.io/api/policy/v1beta1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/rbac/v1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1/zz_generated.prerelease-lifecycle.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1alpha1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/rbac/v1alpha1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1alpha1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1beta1/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/rbac/v1beta1/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/rbac/v1beta1/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/doc.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/generated.pb.go is excluded by !**/*.pb.go, !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/generated.proto is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/register.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/types.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/types_swagger_doc_generated.go is excluded by !vendor/**
  • vendor/k8s.io/api/resource/v1alpha2/zz_generated.deepcopy.go is excluded by !vendor/**
📒 Files selected for processing (1)
  • sys/sys.go (1 hunks)

sys/sys.go Outdated Show resolved Hide resolved
@c3y1huang
Copy link
Contributor

I am not sure about this change. Does this imply that the go-common-lib must always align with the version used in the minimum actively supported Longhorn version? If so, could this potentially become a blocker for updating Kubernetes or other dependencies?

After talking to @derekbit , we've considered two potential approaches:

  1. Align with the Longhorn Manager dep versions: Use the dependency versions specified in longhorn-manager of the minimum actively supported longhorn release.
  2. Versioned branches from go-common-lib: Maintain separate versioned branches for go-common-lib, this can ensure compatibility across different Longhorn component versions.

We will proceed with the first approach, and see how this fits.

Related: longhorn/longhorn-manager#2908

@derekbit derekbit marked this pull request as draft December 16, 2024 08:11
Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit derekbit marked this pull request as ready for review December 16, 2024 08:12
@derekbit derekbit merged commit 2bf72d2 into longhorn:main Dec 16, 2024
8 checks passed
@innobead
Copy link
Member

innobead commented Dec 16, 2024

I am not sure about this change. Does this imply that the go-common-lib must always align with the version used in the minimum actively supported Longhorn version? If so, could this potentially become a blocker for updating Kubernetes or other dependencies?

There should not be an issue unless there is a compatibility problem between versions, as the higher version will be chosen. For example, if a higher k8s-api version is used in longhorn-manager than in go-common-lib, the higher version will take precedence. This concept is the same as you mentioned below.

Align with the Longhorn Manager dep versions: Use the dependency versions specified in longhorn-manager of the minimum actively supported longhorn release.

@innobead
Copy link
Member

innobead commented Dec 16, 2024

2. Versioned branches from go-common-lib: Maintain separate versioned branches for go-common-lib, this can ensure compatibility across different Longhorn component versions.

This should be prevented if possible. This might cause our maintenance efforts. This is why we introduce a shared library like we did for other longhorn go libraries.

We had some pains before when maintaining branched shared libraries like backupstore 1.3/1.4?

@derekbit
Copy link
Member Author

derekbit commented Dec 16, 2024

We had some pains before when maintaining branched shared libraries like backupstore 1.3/1.4?

Yes, it is a dilemma...
If we start branching go-common-libs, then we need to branch go-iscsi-helper, backupstore, longhorn-manager..... all the repos using go-common-libs.

@innobead
Copy link
Member

I added this lib update policy for shared libs in https://github.com/longhorn/longhorn/wiki/Version-Update-Policy#library-depednecy-update-in-shared-libraries for future reference.

cc @longhorn/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants