-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vendor): pin k8s libs to 0.28.5 #95
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (300)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe pull request introduces a debug logging statement in the Changes
Note: This change is purely for debugging purposes and does not modify the function's core logic or behavior. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this change. Does this imply that the go-common-lib
must always align with the version used in the minimum actively supported Longhorn version? If so, could this potentially become a blocker for updating Kubernetes
or other dependencies?
da5e018
to
11e0f79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 77.25% 77.30% +0.04%
==========================================
Files 37 37
Lines 2071 2071
==========================================
+ Hits 1600 1601 +1
+ Misses 342 341 -1
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
sys/sys.go (1)
Line range hint
115-122
: Enhance error context for debuggingThe debug log could be more helpful if it preserved context for error cases. Consider moving the logging to include both success and error scenarios.
numbers := strings.Split(strings.TrimSpace(string(data)), ":") -logrus.Infof("Debug ========> %v", numbers) major, err := readDeviceNumber(numbers, 0) if err != nil { + logrus.WithFields(logrus.Fields{ + "deviceName": deviceName, + "numbers": numbers, + "error": err, + }).Debug("Failed to parse major device number") logrus.WithError(err).Warnf("failed to read device %s major", deviceName) continue }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (299)
go.mod
is excluded by!go.mod
go.sum
is excluded by!**/*.sum
,!go.sum
vendor/github.com/evanphx/json-patch/.gitignore
is excluded by!vendor/**
vendor/github.com/evanphx/json-patch/LICENSE
is excluded by!vendor/**
vendor/github.com/evanphx/json-patch/README.md
is excluded by!vendor/**
vendor/github.com/evanphx/json-patch/errors.go
is excluded by!vendor/**
vendor/github.com/evanphx/json-patch/merge.go
is excluded by!vendor/**
vendor/github.com/evanphx/json-patch/patch.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/.gitignore
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/.golangci.yml
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/CODE_OF_CONDUCT.md
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/CONTRIBUTING.md
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/LICENSE
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/README.md
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/SECURITY.md
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/bytestring.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/cache.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/common.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/decode.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/diagnose.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/doc.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/encode.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/encode_map.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/encode_map_go117.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/simplevalue.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/stream.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/structfields.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/tag.go
is excluded by!vendor/**
vendor/github.com/fxamacker/cbor/v2/valid.go
is excluded by!vendor/**
vendor/github.com/moby/sys/userns/userns.go
is excluded by!vendor/**
vendor/github.com/moby/sys/userns/userns_linux.go
is excluded by!vendor/**
vendor/github.com/moby/sys/userns/userns_linux_fuzzer.go
is excluded by!vendor/**
vendor/github.com/moby/sys/userns/userns_unsupported.go
is excluded by!vendor/**
vendor/github.com/x448/float16/.travis.yml
is excluded by!vendor/**
vendor/github.com/x448/float16/README.md
is excluded by!vendor/**
vendor/github.com/x448/float16/float16.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/.travis.yml
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/LICENSE
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/LICENSE.libyaml
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/NOTICE
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/README.md
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/apic.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/decode.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/emitterc.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/encode.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/parserc.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/readerc.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/resolve.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/scannerc.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/sorter.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/writerc.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/yaml.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/yamlh.go
is excluded by!vendor/**
vendor/gopkg.in/yaml.v2/yamlprivateh.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/admissionregistration/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/admissionregistration/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/apidiscovery/v2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2/register.go
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/apidiscovery/v2beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/apidiscovery/v2beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/apiserverinternal/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/apps/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/apps/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1beta2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/apps/v1beta2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1beta2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/apps/v1beta2/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/authentication/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/authentication/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/authentication/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/authentication/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/authorization/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/authorization/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/authorization/v1beta1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/autoscaling/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/autoscaling/v2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/autoscaling/v2beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2beta2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/autoscaling/v2beta2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2beta2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/autoscaling/v2beta2/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/batch/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/batch/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/batch/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/certificates/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/certificates/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1alpha1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/certificates/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/certificates/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/coordination/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/register.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1alpha2/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/coordination/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/coordination/v1beta1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/annotation_key_constants.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/core/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/objectreference.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/core/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/discovery/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/discovery/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/discovery/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/events/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/events/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/events/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/events/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/events/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/events/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/events/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/extensions/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/extensions/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/extensions/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1alpha1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta2/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta3/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta3/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta3/types.go
is excluded by!vendor/**
vendor/k8s.io/api/flowcontrol/v1beta3/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/imagepolicy/v1alpha1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/networking/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/networking/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1alpha1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1alpha1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1alpha1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1alpha1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/networking/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/well_known_labels.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/networking/v1beta1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/node/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/node/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/node/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/node/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/node/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/node/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/node/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/node/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/node/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/policy/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/policy/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/register.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/zz_generated.deepcopy.go
is excluded by!vendor/**
vendor/k8s.io/api/policy/v1beta1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/rbac/v1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1/zz_generated.prerelease-lifecycle.go
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1alpha1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/rbac/v1alpha1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1alpha1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1beta1/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/rbac/v1beta1/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/rbac/v1beta1/types.go
is excluded by!vendor/**
vendor/k8s.io/api/resource/v1alpha2/doc.go
is excluded by!vendor/**
vendor/k8s.io/api/resource/v1alpha2/generated.pb.go
is excluded by!**/*.pb.go
,!vendor/**
vendor/k8s.io/api/resource/v1alpha2/generated.proto
is excluded by!vendor/**
vendor/k8s.io/api/resource/v1alpha2/register.go
is excluded by!vendor/**
vendor/k8s.io/api/resource/v1alpha2/types.go
is excluded by!vendor/**
vendor/k8s.io/api/resource/v1alpha2/types_swagger_doc_generated.go
is excluded by!vendor/**
vendor/k8s.io/api/resource/v1alpha2/zz_generated.deepcopy.go
is excluded by!vendor/**
📒 Files selected for processing (1)
sys/sys.go
(1 hunks)
After talking to @derekbit , we've considered two potential approaches:
We will proceed with the first approach, and see how this fits. Related: longhorn/longhorn-manager#2908 |
Signed-off-by: Derek Su <derek.su@suse.com>
There should not be an issue unless there is a compatibility problem between versions, as the higher version will be chosen. For example, if a higher k8s-api version is used in longhorn-manager than in go-common-lib, the higher version will take precedence. This concept is the same as you mentioned below.
|
This should be prevented if possible. This might cause our maintenance efforts. This is why we introduce a shared library like we did for other longhorn go libraries. We had some pains before when maintaining branched shared libraries like backupstore 1.3/1.4? |
Yes, it is a dilemma... |
I added this lib update policy for shared libs in https://github.com/longhorn/longhorn/wiki/Version-Update-Policy#library-depednecy-update-in-shared-libraries for future reference. cc @longhorn/dev |
Which issue(s) this PR fixes:
Issue #
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context