fix: update engine naming regex to allow non digit ending #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: longhorn/longhorn 9267 Signed-off-by: Jack Lin <jack.lin@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 79.78% 79.84% +0.06%
==========================================
Files 33 33
Lines 1583 1583
==========================================
+ Hits 1263 1264 +1
+ Misses 204 203 -1
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
innobead
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#9267
Before v1.4.x, users might have engine name like "XXXX-e-12avc" or "XXXX-e-abcd1"
We change to use "-0", "-1" starting from v1.4.4, v1.5.2
longhorn/longhorn-manager#2180
The previous regex didn't allow "XXXX-e-12avc" which has non digit ending
We should fix it