Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-balance): disk in pressure #44

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#4105

What this PR does / why we need it:

  • Add a function to verify if files are the same size.
  • Unit test CopyFile with sparse file.

Special notes for your reviewer:

None

Additional documentation or context

longhorn/longhorn#7576 (comment)

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit force-pushed the feat-auto-balance-node-disks branch from 3167aaa to 9071710 Compare June 25, 2024 06:21
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.15%. Comparing base (3b5852c) to head (a353d42).

Files Patch % Lines
io/file.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   79.19%   79.15%   -0.05%     
==========================================
  Files          32       32              
  Lines        1485     1506      +21     
==========================================
+ Hits         1176     1192      +16     
- Misses        198      201       +3     
- Partials      111      113       +2     
Flag Coverage Δ
unittests 79.15% <80.95%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@derekbit derekbit force-pushed the feat-auto-balance-node-disks branch from 9071710 to a353d42 Compare June 25, 2024 07:00
@derekbit derekbit merged commit d22ff30 into longhorn:main Jun 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants